Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idle_test.test_warning failure #65258

Closed
neologix mannequin opened this issue Mar 25, 2014 · 5 comments
Closed

idle_test.test_warning failure #65258

neologix mannequin opened this issue Mar 25, 2014 · 5 comments
Assignees
@zware
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@neologix
Copy link
Mannequin

neologix mannequin commented Mar 25, 2014

BPO 21059
Nosy @terryjreedy, @vstinner, @zware
Superseder
  • bpo-20035: Clean up Tcl library discovery in Tkinter on Windows
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zware'
closed_at = <Date 2014-07-16.20:43:09.961>
created_at = <Date 2014-03-25.08:12:54.501>
labels = ['type-bug', 'tests']
title = 'idle_test.test_warning failure'
updated_at = <Date 2014-07-16.20:43:09.959>
user = 'https://bugs.python.org/neologix'

    bugs.python.org fields:

    activity = <Date 2014-07-16.20:43:09.959>
actor = 'zach.ware'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2014-07-16.20:43:09.961>
closer = 'zach.ware'
components = ['Tests']
creation = <Date 2014-03-25.08:12:54.501>
creator = 'neologix'
dependencies = []
files = []
hgrepos = []
issue_num = 21059
keywords = []
message_count = 5.0
messages = ['214781', '214784', '214823', '215727', '223272']
nosy_count = 5.0
nosy_names = ['terry.reedy', 'vstinner', 'neologix', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '20035'
type = 'behavior'
url = 'https://bugs.python.org/issue21059'
versions = ['Python 3.5']
    @neologix
    Copy link
    Mannequin Author

    neologix mannequin commented Mar 25, 2014

    Many buildbots are failing with this error:
    """
    ======================================================================
    ERROR: idlelib.idle_test.test_warning (unittest.loader.ModuleImportFailure)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\unittest\case.py", line 57, in testPartExecutor
    yield
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\unittest\case.py", line 574, in run
    testMethod()
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\unittest\loader.py", line 32, in testFailure
    raise exception
ImportError: Failed to import test module: idlelib.idle_test.test_warning
Traceback (most recent call last):
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\unittest\loader.py", line 312, in _find_tests
    module = self._get_module_from_name(name)
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\unittest\loader.py", line 290, in _get_module_from_name
    __import__(name)
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\idlelib\idle_test\test_warning.py", line 19, in <module>
    from idlelib import run
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\idlelib\run.py", line 58, in <module>
    tcl = tkinter.Tcl()
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\tkinter\__init__.py", line 1901, in Tcl
    return Tk(screenName, baseName, className, useTk)
  File "E:\Data\buildslave\cpython\3.x.snakebite-win2k3r2sp2-x86\build\lib\tkinter\__init__.py", line 1805, in __init__
    self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
_tkinter.TclError: Can't find a usable init.tcl in the following directories: 
    E:/Data/buildslave/cpython/3.x.snakebite-win2k3r2sp2-x86/build/lib/tcl8.6 E:/Data/buildslave/cpython/3.x.snakebite-win2k3r2sp2-x86/build/lib/tcl8.6 E:/Data/buildslave/cpython/3.x.snakebite-win2k3r2sp2-x86/lib/tcl8.6 E:/Data/buildslave/cpython/3.x.snakebite-win2k3r2sp2-x86/build/library E:/Data/buildslave/cpython/3.x.snakebite-win2k3r2sp2-x86/library E:/Data/buildslave/cpython/3.x.snakebite-win2k3r2sp2-x86/tcl8.6.1/library E:/Data/buildslave/cpython/tcl8.6.1/library

    This probably means that Tcl wasn't installed properly.
    """

    See e.g. http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/2274/steps/test/logs/stdio

    @neologix neologix mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Mar 25, 2014
    @vstinner
    Copy link
    Member

    It's probably a regression of the changeset c2e2dc6c8769b6f37638149a9e9d0aad5845b3f1:
    "Issue bpo-15968: Incorporated Tcl, Tk, and Tix builds into the Windows build solution. "

    @zware
    Copy link
    Member

    zware commented Mar 25, 2014

    Indeed, although honestly I can't figure out exactly why. However, bpo-20035 should fix the failures; I haven't committed it because the patch is in C and I can't guarantee that I haven't missed anything big. If either of you (or anyone else at all :-) could review that patch for me, I would be very grateful.

    @zware zware self-assigned this Mar 25, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 8, 2014

    New changeset c507da0b573f by Zachary Ware in branch 'default':
    Issue bpo-21059: Temporary measure to make the Windows buildbots useful again.
    http://hg.python.org/cpython/rev/c507da0b573f

    @zware
    Copy link
    Member

    zware commented Jul 16, 2014

    I believe I eventually figured out the reason for the failure, it had to do with the fact that the Tcl/Tk DLLs were copied into PCbuild to avoid adding ..\tcltk[64]\bin to PATH and the persistent issue that tkinter._fix changes environment variables to make init.tcl findable, while regrtest unsets those variables at the end of each test. The issue is successfully worked around in test[-amd64].bat, and should be fixed by bpo-20035 (once reviewed :)).

    Closing this issue.

    @zware zware closed this as completed Jul 16, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zware zware

    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @zware