Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use specific asserts in urllib related tests #64754

Closed
serhiy-storchaka opened this issue Feb 7, 2014 · 4 comments
Closed

Use specific asserts in urllib related tests #64754

serhiy-storchaka opened this issue Feb 7, 2014 · 4 comments
Assignees
@serhiy-storchaka
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 20555
Nosy @pjeby, @orsenthil, @giampaolo, @serhiy-storchaka
Files
  • test_urllib_asserts.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-02-08.13:36:38.778>
created_at = <Date 2014-02-07.21:34:25.132>
labels = ['type-feature', 'tests']
title = 'Use specific asserts in urllib related tests'
updated_at = <Date 2014-02-08.13:36:38.777>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-02-08.13:36:38.777>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-02-08.13:36:38.778>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-02-07.21:34:25.132>
creator = 'serhiy.storchaka'
dependencies = []
files = ['33980']
hgrepos = []
issue_num = 20555
keywords = ['patch']
message_count = 4.0
messages = ['210561', '210565', '210627', '210635']
nosy_count = 5.0
nosy_names = ['pje', 'orsenthil', 'giampaolo.rodola', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20555'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
    @serhiy-storchaka
    Copy link
    Member Author

    The proposed patch makes the urllib, httplib, ftplib, cgi, and wsgiref modules tests use more specific asserts. This will provide more useful failure report.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Feb 7, 2014
    @giampaolo
    Copy link
    Contributor

    Patch LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 8, 2014

    New changeset b21397ca58c7 by Serhiy Storchaka in branch '2.7':
    Issue bpo-20555: Use specific asserts in urllib, httplib, ftplib, cgi, wsgiref tests.
    http://hg.python.org/cpython/rev/b21397ca58c7

    New changeset b6f8d5148a05 by Serhiy Storchaka in branch '3.3':
    Issue bpo-20555: Use specific asserts in urllib, httplib, ftplib, cgi, wsgiref tests.
    http://hg.python.org/cpython/rev/b6f8d5148a05

    New changeset 868675190b34 by Serhiy Storchaka in branch 'default':
    Issue bpo-20555: Use specific asserts in urllib, httplib, ftplib, cgi, wsgiref tests.
    http://hg.python.org/cpython/rev/868675190b34

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you for your review Giampaolo.

    @serhiy-storchaka serhiy-storchaka self-assigned this Feb 8, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @giampaolo @serhiy-storchaka