Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_tests.py: Work around issues 20355 and 20361 #64734

Closed
Arfrever mannequin opened this issue Feb 6, 2014 · 4 comments
Closed

run_tests.py: Work around issues 20355 and 20361 #64734

Arfrever mannequin opened this issue Feb 6, 2014 · 4 comments
Assignees
@serhiy-storchaka
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@Arfrever
Copy link
Mannequin

Arfrever mannequin commented Feb 6, 2014

BPO 20535
Nosy @pitrou, @ezio-melotti, @voidspace, @serhiy-storchaka
Files
  • run_tests.py.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-02-24.13:35:58.025>
created_at = <Date 2014-02-06.21:55:17.227>
labels = ['type-bug', 'tests']
title = 'run_tests.py: Work around issues 20355 and 20361'
updated_at = <Date 2014-02-24.13:35:58.023>
user = 'https://bugs.python.org/Arfrever'

    bugs.python.org fields:

    activity = <Date 2014-02-24.13:35:58.023>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-02-24.13:35:58.025>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-02-06.21:55:17.227>
creator = 'Arfrever'
dependencies = []
files = ['33948']
hgrepos = []
issue_num = 20535
keywords = ['patch']
message_count = 4.0
messages = ['210423', '210791', '212086', '212096']
nosy_count = 6.0
nosy_names = ['pitrou', 'ezio.melotti', 'Arfrever', 'michael.foord', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20535'
versions = ['Python 3.3', 'Python 3.4']
    @Arfrever
    Copy link
    Mannequin Author

    Arfrever mannequin commented Feb 6, 2014

    Tools/scripts/run_tests.py contains:

    def main(regrtest_args):
    args = [sys.executable,
            '-W', 'default',      # Warnings set to 'default'
            '-bb',                # Warnings about bytes/bytearray
            '-E',                 # Ignore environment variables
            ]

    As described in issues bpo-20355 and bpo-20361, -bb fails to enable BytesWarning errors.

    I suggest to include a small workaround, which will be deleted in Python 3.5. I attach patch.

    @Arfrever Arfrever mannequin added the tests Tests in the Lib/test dir label Feb 6, 2014
    @serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Feb 8, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Feb 9, 2014

    This sounds fine.

    @serhiy-storchaka serhiy-storchaka self-assigned this Feb 24, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 24, 2014

    New changeset c89e495cdff8 by Serhiy Storchaka in branch '3.3':
    Issue bpo-20535: PYTHONWARNING no longer affects the run_tests.py script.
    http://hg.python.org/cpython/rev/c89e495cdff8

    New changeset 656d0e273ccb by Serhiy Storchaka in branch 'default':
    Issue bpo-20535: PYTHONWARNING no longer affects the run_tests.py script.
    http://hg.python.org/cpython/rev/656d0e273ccb

    @serhiy-storchaka
    Copy link
    Member

    LGTM too. Thank you for your patch Arfrever.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @serhiy-storchaka