Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot #64671

Closed
vstinner opened this issue Feb 1, 2014 · 7 comments
Closed

test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot #64671

vstinner opened this issue Feb 1, 2014 · 7 comments

Comments

@vstinner
Copy link
Member

vstinner commented Feb 1, 2014

BPO 20472
Nosy @gvanrossum, @pitrou, @vstinner, @ned-deily
Files
  • asyncio_pty_osx.patch
  • asyncio_pty_osx-2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-02-02.23:37:54.830>
    created_at = <Date 2014-02-01.03:20:19.009>
    labels = []
    title = 'test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot'
    updated_at = <Date 2014-02-02.23:37:54.829>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2014-02-02.23:37:54.829>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2014-02-02.23:37:54.830>
    closer = 'vstinner'
    components = []
    creation = <Date 2014-02-01.03:20:19.009>
    creator = 'vstinner'
    dependencies = []
    files = ['33875', '33878']
    hgrepos = []
    issue_num = 20472
    keywords = ['patch']
    message_count = 7.0
    messages = ['209870', '209873', '209880', '210036', '210052', '210053', '210054']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'pitrou', 'vstinner', 'ned.deily', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue20472'
    versions = []

    @vstinner
    Copy link
    Member Author

    vstinner commented Feb 1, 2014

    http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/7801/steps/test/logs/stdio

    ======================================================================
    FAIL: test_write_pty (test.test_asyncio.test_events.PollEventLoopTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/test_asyncio/test_events.py", line 1105, in test_write_pty
        self.assertEqual(b'1', data)
    AssertionError: b'1' != b''

    @gvanrossum
    Copy link
    Member

    Well, there were other pty problems on OS X versions before Mavericks (10.9) -- let's just disable this test too using the same approach.

    @ned-deily
    Copy link
    Member

    FYI, besides 10.4 (Tiger), the test also fails on OS X 10.5 but appears to pass on 10.6 and later releases.

    @vstinner
    Copy link
    Member Author

    vstinner commented Feb 2, 2014

    Here is a patch to skip the tests for SelectSelector on Mac OS X older than 10.6 (Snow Leopard).

    @ned: Could you please try it? I don't have access to such old Mac OS X versions. (I now only have a iMac running 10.9).

    @vstinner
    Copy link
    Member Author

    vstinner commented Feb 2, 2014

    Oh, Ned told me that tests using the PollSelector are still failing. I forgot that poll() is also supported on OS X.

    Please try this new patch.

    @ned-deily
    Copy link
    Member

    With asyncio_pty_osx-2.patch, test_asyncio now passes on OS X 10.4.11 and 10.5.8.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 2, 2014

    New changeset 21a4ebf5a170 by Victor Stinner in branch 'default':
    Issue bpo-20472: test_asyncio: skip PTY tests on Mac OS X older than 10.6
    http://hg.python.org/cpython/rev/21a4ebf5a170

    New changeset 0a71d29b970a by Victor Stinner in branch 'default':
    Issue bpo-20472: asyncio: Adjust the note about Mac OS X on PTY, specify that it
    http://hg.python.org/cpython/rev/0a71d29b970a

    @vstinner vstinner closed this as completed Feb 2, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants