Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SQLite to 3.8.3 with 3.4.0 Windows and OS X installers #64664

Closed
ned-deily opened this issue Jan 31, 2014 · 13 comments
Closed

Upgrade SQLite to 3.8.3 with 3.4.0 Windows and OS X installers #64664

ned-deily opened this issue Jan 31, 2014 · 13 comments
Assignees
@loewis
Labels
build The build process and cross-build release-blocker

Comments

@ned-deily
Copy link
Member

BPO 20465
Nosy @loewis, @larryhastings, @ned-deily

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2014-03-02.18:45:20.493>
created_at = <Date 2014-01-31.20:57:25.356>
labels = ['build', 'release-blocker']
title = 'Upgrade SQLite to 3.8.3 with 3.4.0 Windows and OS X installers'
updated_at = <Date 2014-07-10.11:35:40.838>
user = 'https://github.com/ned-deily'

bugs.python.org fields:

activity = <Date 2014-07-10.11:35:40.838>
actor = 'berker.peksag'
assignee = 'loewis'
closed = True
closed_date = <Date 2014-03-02.18:45:20.493>
closer = 'loewis'
components = ['Build']
creation = <Date 2014-01-31.20:57:25.356>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 20465
keywords = []
message_count = 13.0
messages = ['209830', '210284', '210285', '210287', '210288', '210289', '212496', '212522', '212523', '212525', '212575', '212577', '213837']
nosy_count = 5.0
nosy_names = ['loewis', 'ghaering', 'larry', 'ned.deily', 'python-dev']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20465'
versions = ['Python 3.4']
@ned-deily
Copy link
Member Author

The SQLite project has requested that we consider shipping SQLite version 3.8.3 with the Windows and OS X binary installers for Python 3.4.0, primarily to make available support for the new Common Table Expressions feature. 3.8.3 is expected to be officially released 2014-02-03.

@ned-deily ned-deily added release-blocker build The build process and cross-build labels Jan 31, 2014
@python-dev
Copy link
Mannequin

python-dev mannequin commented Feb 5, 2014

New changeset 32af4954e46a by Ned Deily in branch 'default':
Issue bpo-20465: Update SQLite shipped with OS X installer to 3.8.3.
http://hg.python.org/cpython/rev/32af4954e46a

@ned-deily
Copy link
Member Author

With the consent of the release manager, the SQLite library to be shipped with the OS X installers for 3.4.0 has been updated to 3.8.3.

Assigning to MvL for the Windows installers.

@larryhastings
Copy link
Contributor

I assumed that you guys took responsibility for the binary installers, and the decision was up to you. But I'm happy to take ultimate responsibility for the decision to ship SQLite 3.8.3 with 3.4 if that's what policy demands, and yes I give it my blessing.

According to the release notes:
http://www.sqlite.org/draft/changes.html
there are two new constants: SQLITE_DETERMINISTIC and SQLITE_READONLY_DBMOVED. It looks like there's no point in adding these int constants to the module, as the latter is an error (and those never escape the module) and the former is a flag to creating a "function" (and there's no exposed means to pass in flags here).

Do we need to do anything to support additional features in 3.8.3, like this SQLITE_DETERMINISTIC flag?

Roping in "ghaering", the sqlite expert from the list.

@ned-deily
Copy link
Member Author

Larry, I thought we had agreed on everything in email so I wasn't expecting any further pronouncements from you, just documenting that post feature cutoff decision. I think we're good to go.

@larryhastings
Copy link
Contributor

Ned, yeah I recall the discussion, and I didn't think you needed a further pronouncement from me. I was just saying, I'm not sure you *ever* needed a pronouncement from me. ;-)

Everything's perfectly alright now. We're fine... we're all fine here now. Thank you. How are you?

@loewis
Copy link
Mannequin

loewis mannequin commented Mar 1, 2014

3.8.3 has been superseded by 3.8.3.1.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Mar 1, 2014

New changeset 5fa3f6d82d61 by Ned Deily in branch 'default':
Issue bpo-20465: Update OS X installer build to use SQLite 3.8.0.1.
http://hg.python.org/cpython/rev/5fa3f6d82d61

@python-dev
Copy link
Mannequin

python-dev mannequin commented Mar 1, 2014

New changeset a8470f88e7b4 by Ned Deily in branch 'default':
Issue bpo-20465: fix NEWS typo (it's 3.8.3.1)
http://hg.python.org/cpython/rev/a8470f88e7b4

@ned-deily
Copy link
Member Author

"Fix a bug (ticket 4c86b126f2) that causes rows to go missing on some queries with OR clauses and IS NOT NULL operators in the WHERE clause, when the SQLITE_ENABLE_STAT3 or SQLITE_ENABLE_STAT4 compile-time options are used."

http://www.sqlite.org/releaselog/3_8_3_1.html

We don't use those compile-time options for the OS X build, so, if this is the only meaningful bug, it may be a no-op. The tests pass before and after. Still, it's probably better to update now. I've opened bpo-20818 as a cherry pick request for 3.4.0.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Mar 2, 2014

New changeset 9459f517d854 by Martin v. Löwis in branch 'default':
Issue bpo-20465: Update Windows installer to SQLite 3.8.3.1.
http://hg.python.org/cpython/rev/9459f517d854

@loewis
Copy link
Mannequin

loewis mannequin commented Mar 2, 2014

Cherry-picking in bpo-20832.

@loewis loewis mannequin closed this as completed Mar 2, 2014
@python-dev
Copy link
Mannequin

python-dev mannequin commented Mar 17, 2014

New changeset 7260dffad495 by Ned Deily in branch '3.4':
Issue bpo-20465: Update OS X installer build to use SQLite 3.8.0.1.
http://hg.python.org/cpython/rev/7260dffad495

New changeset 1f922e9742b7 by Ned Deily in branch '3.4':
Issue bpo-20465: fix NEWS typo (it's 3.8.3.1)
http://hg.python.org/cpython/rev/1f922e9742b7

New changeset 9be3bf7b5b8d by Martin v. Löwis in branch '3.4':
Issue bpo-20465: Update Windows installer to SQLite 3.8.3.1.
http://hg.python.org/cpython/rev/9be3bf7b5b8d

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loewis loewis

Labels
build The build process and cross-build release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ned-deily @larryhastings