Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android's failure to expose SYS_* system call constants causes _posixsubprocess cross-compilation to fail #64506

Closed
shiz mannequin opened this issue Jan 19, 2014 · 6 comments
Closed

Android's failure to expose SYS_* system call constants causes _posixsubprocess cross-compilation to fail #64506

shiz mannequin opened this issue Jan 19, 2014 · 6 comments
Assignees
@gpshead
Labels
build The build process and cross-build

Comments

@shiz
Copy link
Mannequin

shiz mannequin commented Jan 19, 2014

BPO 20307
Nosy @gpshead
Files
  • Python-3.4.0tip-expose-SYS_getdents64-on-android.patch: Patch that manually defines SYS_getdents64 on Android from Bionic internals.
  • Python-3.4.0tip-expose-SYS_getdents64-on-android-v2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
closed_at = <Date 2014-04-14.20:42:34.130>
created_at = <Date 2014-01-19.18:27:50.560>
labels = ['build']
title = "Android's failure to expose SYS_* system call constants causes _posixsubprocess cross-compilation to fail"
updated_at = <Date 2014-04-14.20:42:34.129>
user = 'https://bugs.python.org/shiz'

    bugs.python.org fields:

    activity = <Date 2014-04-14.20:42:34.129>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2014-04-14.20:42:34.130>
closer = 'gregory.p.smith'
components = ['Cross-Build']
creation = <Date 2014-01-19.18:27:50.560>
creator = 'shiz'
dependencies = []
files = ['33551', '33584']
hgrepos = []
issue_num = 20307
keywords = ['patch']
message_count = 6.0
messages = ['208488', '208490', '208607', '208611', '208612', '216204']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'python-dev', 'shiz']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue20307'
versions = ['Python 3.4', 'Python 3.5']
    @shiz
    Copy link
    Mannequin Author

    shiz mannequin commented Jan 19, 2014

    Bionic, Android's C library, fails to expose the SYS_* constants used for the syscall(1) interface, which causes compilation of the _posixsubprocess module to fail as it directly attempts to call SYS_getdents64.

    Attached is an experimental patch that manually defines SYS_getdents64 from Bionic's internals.

    @shiz shiz mannequin added build The build process and cross-build labels Jan 19, 2014
    @shiz
    Copy link
    Mannequin Author

    shiz mannequin commented Jan 19, 2014

    I of course meant the syscall(2) interface, not syscall(1).

    @gpshead
    Copy link
    Member

    gpshead commented Jan 21, 2014

    The patch seems reasonable. i'd modify it slightly to include a check the SYS_getdents64 is not already defined before doing the #define.

    @gpshead gpshead self-assigned this Jan 21, 2014
    @shiz
    Copy link
    Mannequin Author

    shiz mannequin commented Jan 21, 2014

    That's probably a good idea. Fixed patch attached.

    @shiz
    Copy link
    Mannequin Author

    shiz mannequin commented Jan 21, 2014

    Please take note of the discussion in bpo-20305 if you were planning to merge this, by the way.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 14, 2014

    New changeset 211eeb97b352 by Gregory P. Smith in branch '3.4':
    Add conditional code for android's lack of definition of SYS_getdent64.
    http://hg.python.org/cpython/rev/211eeb97b352

    New changeset 9f89958ded0a by Gregory P. Smith in branch 'default':
    Add conditional code for android's lack of definition of SYS_getdent64.
    http://hg.python.org/cpython/rev/9f89958ded0a

    @gpshead gpshead closed this as completed Apr 14, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gpshead gpshead

    Labels
    build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gpshead