Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test_modules_search_builtin() in test_pydoc #64327

Open
ericsnowcurrently opened this issue Jan 5, 2014 · 11 comments
Open

Re-enable test_modules_search_builtin() in test_pydoc #64327

ericsnowcurrently opened this issue Jan 5, 2014 · 11 comments
Assignees
@ericsnowcurrently
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

BPO 20128
Nosy @vstinner, @ericsnowcurrently, @serhiy-storchaka, @koobs

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/ericsnowcurrently'
closed_at = None
created_at = <Date 2014-01-05.07:10:27.797>
labels = ['type-bug', 'tests', '3.9', '3.10', '3.11']
title = 'Re-enable test_modules_search_builtin() in test_pydoc'
updated_at = <Date 2021-12-12.00:39:32.647>
user = 'https://github.com/ericsnowcurrently'

bugs.python.org fields:

activity = <Date 2021-12-12.00:39:32.647>
actor = 'iritkatriel'
assignee = 'eric.snow'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2014-01-05.07:10:27.797>
creator = 'eric.snow'
dependencies = []
files = []
hgrepos = []
issue_num = 20128
keywords = []
message_count = 11.0
messages = ['207353', '207369', '211952', '211954', '213824', '215998', '220358', '236920', '236953', '236955', '236963']
nosy_count = 6.0
nosy_names = ['vstinner', 'Arfrever', 'python-dev', 'eric.snow', 'serhiy.storchaka', 'koobs']
pr_nums = []
priority = 'high'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20128'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
@ericsnowcurrently
Copy link
Member Author

The test (added in issue bpo-20123) broke one of the stable FreeBSD buildbots:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6102

The log for that test run indicates the traceback and the test can be found in Lib/test/test_pydoc.py (PydocImportTest.test_modules_search_builtin).

The problem could be one (or more) of several possibilities:

  • the test is broken in an esoteric way
  • the buildbot has issues
  • the platform has issues
  • the test exposes some other underlying bug elsewhere

The test itself is not critical but I hope to re-enable it before beta 2 ends in a couple weeks.

Stefan: any insight you could offer on the problem, particularly relative to the platform and buildbot, would be greatly appreciated.

@ericsnowcurrently ericsnowcurrently self-assigned this Jan 5, 2014
@ericsnowcurrently ericsnowcurrently added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jan 5, 2014
@skrah
Copy link
Mannequin

skrah mannequin commented Jan 5, 2014

The buildbot runs --without-doc-strings. Usually you just have to add the
@requires_docstrings decorator to some tests.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Feb 22, 2014

New changeset 13edfab6c3c0 by Eric Snow in branch 'default':
Issue bpo-20484: Disable the 2 remaining "modules" tests in test_pydoc.
http://hg.python.org/cpython/rev/13edfab6c3c0

@ericsnowcurrently
Copy link
Member Author

The other two test_modules* tests in test_pydoc are also having issues and I've likewise disabled them (see bpo-20484). They'll need to be investigated and re-enabled too.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Mar 17, 2014

New changeset 7cfb3db36ec6 by Eric Snow in branch '3.4':
Issue bpo-20484: Disable the 2 remaining "modules" tests in test_pydoc.
http://hg.python.org/cpython/rev/7cfb3db36ec6

@koobs
Copy link

koobs commented Apr 13, 2014

test_synopsis_sourceless is also failing on koobs-freebsd9 (3.4) and has been for a while. Failing test inlined here, for full buildlog, see msg215997 in bpo-20123

======================================================================
ERROR: test_synopsis_sourceless (test.test_pydoc.PydocDocTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.4.koobs-freebsd9/build/Lib/test/test_pydoc.py", line 504, in test_synopsis_sourceless
    synopsis = pydoc.synopsis(filename)
  File "/usr/home/buildbot/python/3.4.koobs-freebsd9/build/Lib/pydoc.py", line 238, in synopsis
    mtime = os.stat(filename).st_mtime
FileNotFoundError: [Errno 2] No such file or directory: '/usr/home/buildbot/python/3.4.koobs-freebsd9/build/Lib/__pycache__/os.cpython-34.pyc'

@vstinner
Copy link
Member

Many test_pydoc tests are failing on the FreeBSD 9 buildbot, example:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6870/steps/test/logs/stdio

======================================================================
FAIL: test_html_doc (test.test_pydoc.PydocDocTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/buildarea/3.x.krah-freebsd/build/Lib/test/test_pydoc.py", line 418, in test_html_doc
    self.fail("outputs are not equal, see diff above")
AssertionError: outputs are not equal, see diff above

======================================================================
FAIL: test_text_doc (test.test_pydoc.PydocDocTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/buildarea/3.x.krah-freebsd/build/Lib/test/test_pydoc.py", line 432, in test_text_doc
    self.fail("outputs are not equal, see diff above")
AssertionError: outputs are not equal, see diff above

@BreamoreBoy
Copy link
Mannequin

BreamoreBoy mannequin commented Feb 28, 2015

Whilst testing bpo-19980 I noticed that three tests are still skipped.

@serhiy-storchaka
Copy link
Member

I don't know what errors was on FreeBSD (logs are no longer available), but these tests modify sys.path and the list of weakrefs to logging handlers. They also require relative long time to run.

@serhiy-storchaka
Copy link
Member

As said koobs, the full log was attached to bpo-20123.

@serhiy-storchaka
Copy link
Member

With test_synopsis_sourceless and test_non_ascii there were different issues, related to -OO. Fixed in changesets 663a83c1d42d, d7b3e722152d, 94edd0ef4c2a.

@iritkatriel iritkatriel added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels Dec 12, 2021
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vstinner @koobs @iritkatriel @ericsnowcurrently @serhiy-storchaka