Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing "q" and "Q" to multiprocessing.sharedctypes #64095

Closed
anntzer mannequin opened this issue Dec 5, 2013 · 9 comments
Closed

Exposing "q" and "Q" to multiprocessing.sharedctypes #64095

anntzer mannequin opened this issue Dec 5, 2013 · 9 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@anntzer
Copy link
Mannequin

anntzer mannequin commented Dec 5, 2013

BPO 19896
Nosy @pitrou, @vstinner, @benjaminp, @gareth-rees
PRs
  • bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes #2741
    		•
    Files
  • multiprocessing-longlong.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-07-22.10:14:07.040>
created_at = <Date 2013-12-05.11:13:04.147>
labels = ['3.7', 'type-feature', 'library']
title = 'Exposing "q" and "Q" to multiprocessing.sharedctypes'
updated_at = <Date 2017-07-22.10:14:07.039>
user = 'https://github.com/anntzer'

    bugs.python.org fields:

    activity = <Date 2017-07-22.10:14:07.039>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2017-07-22.10:14:07.040>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2013-12-05.11:13:04.147>
creator = 'Antony.Lee'
dependencies = []
files = ['32985']
hgrepos = []
issue_num = 19896
keywords = ['patch']
message_count = 9.0
messages = ['205287', '298372', '298543', '298546', '298547', '298548', '298793', '298797', '298800']
nosy_count = 5.0
nosy_names = ['pitrou', 'vstinner', 'benjamin.peterson', 'sbt', 'gdr@garethrees.org']
pr_nums = ['2741']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19896'
versions = ['Python 3.7']
    @anntzer
    Copy link
    Mannequin Author

    anntzer mannequin commented Dec 5, 2013

    multiprocessing.sharedctypes was not updated after the "q" (c_longlong) and "Q" (c_ulonglong) typecodes were added to the array module (the docs claim that the typecode can be "one character typecode of the kind used by the array module"). The attached patch (just adding an entry to the typecode-to-type dict, as well as some more tests) fixes the issue.

    @anntzer anntzer mannequin added the stdlib Python modules in the Lib dir label Dec 5, 2013
    @gareth-rees
    Copy link
    Mannequin

    gareth-rees mannequin commented Jul 14, 2017

    Patch looks good to me. The test cases are not very systematic (why only int, double, and long long?), but that's not the fault of the patch and shouldn't prevent its being applied.

    @pitrou
    Copy link
    Member

    pitrou commented Jul 17, 2017

    Uh, it's a pity this patch has been overlooked.
    Gareth, would you want to make a Github PR out of this?

    @pitrou pitrou added 3.7 (EOL) end of life type-feature A feature request or enhancement labels Jul 17, 2017
    @gareth-rees
    Copy link
    Mannequin

    gareth-rees mannequin commented Jul 17, 2017

    Has Antony Lee has made a copyright assignment?

    @pitrou
    Copy link
    Member

    pitrou commented Jul 17, 2017

    According to the asterisk displayed right of his name, he has, yes.

    @gareth-rees
    Copy link
    Mannequin

    gareth-rees mannequin commented Jul 17, 2017

    (If he hasn't, I don't think I can make a PR because I read his patch and so any implementation I make now is based on his patch and so potentially infringes his copyright.)

    @pitrou
    Copy link
    Member

    pitrou commented Jul 21, 2017

    New changeset 3913bad by Antoine Pitrou (Gareth Rees) in branch 'master':
    bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes (bpo-2741)
    3913bad

    @pitrou pitrou closed this as completed Jul 21, 2017
    @vstinner
    Copy link
    Member

    Unhappy buildbot:

    http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/1065/steps/test/logs/stdio

    ...
    File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_multiprocessing_fork.py", line 2, in <module>
    import test._test_multiprocessing
    File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py", line 3180, in <module>
    class _Foo(Structure):
    File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py", line 3184, in _Foo
    ('z', c_longlong,)
    NameError: name 'c_longlong' is not defined

    @vstinner vstinner reopened this Jul 21, 2017
    @pitrou
    Copy link
    Member

    pitrou commented Jul 21, 2017

    Apparently that buildbot doesn't have libffi. I submitted a PR in #2802.

    @pitrou pitrou closed this as completed Jul 22, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @pitrou