Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure documentation for PEP 451 is finished #63909

Closed
brettcannon opened this issue Nov 22, 2013 · 5 comments
Closed

Make sure documentation for PEP 451 is finished #63909

brettcannon opened this issue Nov 22, 2013 · 5 comments
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

BPO 19710
Nosy @brettcannon, @ncoghlan, @ezio-melotti, @ericsnowcurrently

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-12-19.06:10:18.319>
created_at = <Date 2013-11-22.16:45:05.463>
labels = ['type-feature', 'docs']
title = 'Make sure documentation for PEP 451 is finished'
updated_at = <Date 2013-12-19.06:10:18.317>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-12-19.06:10:18.317>
actor = 'eric.snow'
assignee = 'docs@python'
closed = True
closed_date = <Date 2013-12-19.06:10:18.319>
closer = 'eric.snow'
components = ['Documentation']
creation = <Date 2013-11-22.16:45:05.463>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 19710
keywords = []
message_count = 5.0
messages = ['203804', '205887', '206403', '206406', '206582']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ncoghlan', 'ezio.melotti', 'Arfrever', 'docs@python', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19710'
versions = ['Python 3.4']
@brettcannon
Copy link
Member Author

This includes both importlib.rst and docstrings for various methods.

@brettcannon brettcannon added the docs Documentation in the Doc dir label Nov 22, 2013
@ericsnowcurrently
Copy link
Member

I've attached a patch to bpo-19713 (file33088) that adds documentation for the new APIs. Also, there were some good reviews in bpo-18864 (especially for file32381) that never got fully addressed.

@ericsnowcurrently
Copy link
Member

New changeset 2c27c0e5bc50 by Eric Snow in branch 'default':
Issue bpo-19713: Update importlib docs for module spec changes, including deprecations.
http://hg.python.org/cpython/rev/2c27c0e5bc50

New changeset b78de8029606 by Eric Snow in branch 'default':
Issue bpo-19713: Fix mistakes in the import page of language reference.
http://hg.python.org/cpython/rev/b78de8029606

@ericsnowcurrently ericsnowcurrently added the type-feature A feature request or enhancement label Dec 17, 2013
@ericsnowcurrently
Copy link
Member

I'm leaving this as pending for the moment in case we notice anything I missed.

@ericsnowcurrently
Copy link
Member

If anyone notices any issues with the doc changes, please open a new issue.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @ericsnowcurrently