Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pydoc to PEP 451 #63902

Closed
brettcannon opened this issue Nov 22, 2013 · 5 comments
Closed

Update pydoc to PEP 451 #63902

brettcannon opened this issue Nov 22, 2013 · 5 comments
Assignees
@ericsnowcurrently
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

BPO 19703
Nosy @brettcannon, @ncoghlan, @ericsnowcurrently
Dependencies
  • bpo-20123: pydoc.synopsis fails to load binary modules
    		•
    Files
  • issue19703-use-new-api.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2014-01-07.03:52:46.106>
created_at = <Date 2013-11-22.16:37:12.089>
labels = ['type-feature', 'library']
title = 'Update pydoc to PEP 451'
updated_at = <Date 2014-01-07.03:52:46.105>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2014-01-07.03:52:46.105>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2014-01-07.03:52:46.106>
closer = 'eric.snow'
components = ['Library (Lib)']
creation = <Date 2013-11-22.16:37:12.089>
creator = 'brett.cannon'
dependencies = ['20123']
files = ['33313']
hgrepos = []
issue_num = 19703
keywords = ['patch']
message_count = 5.0
messages = ['205352', '207216', '207320', '207357', '207502']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'ncoghlan', 'Arfrever', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19703'
versions = ['Python 3.4']
    @brettcannon brettcannon added the stdlib Python modules in the Lib dir label Nov 22, 2013
    @ericsnowcurrently
    Copy link
    Member

    Here are the functions that should (?) be updated:

    synopsis()
importfile()
safeimport()?
HTMLDoc.docmodule()
HTMLDoc.index()
TextDoc.docmodule()
ModuleScanner.run()?

    @ericsnowcurrently ericsnowcurrently changed the title Upate pydoc to PEP 451 Update pydoc to PEP 451 Dec 6, 2013
    @ericsnowcurrently
    Copy link
    Member

    Here's a patch that updates pydoc to move away from find_module/load_module.

    These 4 don't need to change for PEP-451:

    safeimport()
HTMLDoc.docmodule()
HTMLDoc.index()
TextDoc.docmodule()

    @ericsnowcurrently
    Copy link
    Member

    Here's a new patch relative to the patch for issue bpo-20123.

    @ericsnowcurrently
    Copy link
    Member

    Here's a slightly updated patch.

    @ericsnowcurrently ericsnowcurrently self-assigned this Jan 5, 2014
    @ericsnowcurrently ericsnowcurrently added the type-feature A feature request or enhancement label Jan 5, 2014
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 7, 2014

    New changeset f67ccb4490ea by Eric Snow in branch 'default':
    Issue bpo-19703: Update pydoc to use the new importer APIs.
    http://hg.python.org/cpython/rev/f67ccb4490ea

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericsnowcurrently ericsnowcurrently

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @ericsnowcurrently