Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_ssl won't compile with OSX 10.9 SDK #63881

Closed
ronaldoussoren opened this issue Nov 21, 2013 · 4 comments
Closed

_ssl won't compile with OSX 10.9 SDK #63881

ronaldoussoren opened this issue Nov 21, 2013 · 4 comments
Assignees
@tiran
Labels
build The build process and cross-build extension-modules C modules in the Modules dir OS-mac

Comments

@ronaldoussoren
Copy link
Contributor

BPO 19682
Nosy @ronaldoussoren, @tiran

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2013-11-21.15:47:34.501>
created_at = <Date 2013-11-21.15:09:42.315>
labels = ['extension-modules', 'OS-mac', 'build']
title = "_ssl won't compile with OSX 10.9 SDK"
updated_at = <Date 2013-11-21.15:47:34.500>
user = 'https://github.com/ronaldoussoren'

bugs.python.org fields:

activity = <Date 2013-11-21.15:47:34.500>
actor = 'ronaldoussoren'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2013-11-21.15:47:34.501>
closer = 'ronaldoussoren'
components = ['Extension Modules', 'macOS']
creation = <Date 2013-11-21.15:09:42.315>
creator = 'ronaldoussoren'
dependencies = []
files = []
hgrepos = []
issue_num = 19682
keywords = ['3.3regression']
message_count = 4.0
messages = ['203634', '203635', '203640', '203645']
nosy_count = 3.0
nosy_names = ['ronaldoussoren', 'christian.heimes', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue19682'
versions = ['Python 3.4']
@ronaldoussoren
Copy link
Contributor Author

I get a compilation error for _ssl when building on OSX 10.9 using the 10.9 SDK, the relevant error:

/Users/ronald/Projects/python/rw/default/Modules/_ssl.c:1029:24: error: no member named 'crldp' in 'struct x509_st'
dps = certificate->crldp;
~~~~~~~~~~~ ^

Looking at /usr/include/openssl/x509.h in the 10.9 SDK that does not have a crldp member:

struct x509_st
        {
        X509_CINF *cert_info;
        X509_ALGOR *sig_alg;
        ASN1_BIT_STRING *signature;
        int valid;
        int references;
        char *name;
        CRYPTO_EX_DATA ex_data;
        /* These contain copies of various extension values */
        long ex_pathlen;
        long ex_pcpathlen;
        unsigned long ex_flags;
        unsigned long ex_kusage;
        unsigned long ex_xkusage;
        unsigned long ex_nscert;
        ASN1_OCTET_STRING *skid;
        struct AUTHORITY_KEYID_st *akid;
        X509_POLICY_CACHE *policy_cache;
#ifndef OPENSSL_NO_RFC3779
        STACK_OF(IPAddressFamily) *rfc3779_addr;
        struct ASIdentifiers_st *rfc3779_asid;
#endif
#ifndef OPENSSL_NO_SHA
        unsigned char sha1_hash[SHA_DIGEST_LENGTH];
#endif
        X509_CERT_AUX *aux;
        } /* X509 */;

Note that OSX ships a fairly ancient version of OpenSSL, libssl.dylib is 0.9.8.

(Marked as a regression because 3.3 and 2.7 can be build with the system version of OpenSSL).

@ronaldoussoren ronaldoussoren self-assigned this Nov 21, 2013
@ronaldoussoren ronaldoussoren added extension-modules C modules in the Modules dir OS-mac build The build process and cross-build labels Nov 21, 2013
@tiran
Copy link
Member

tiran commented Nov 21, 2013

It's my fault and related to bpo-18379. I'll fix it.

@tiran tiran assigned tiran and unassigned ronaldoussoren Nov 21, 2013
@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 21, 2013

New changeset 40bfddda43d4 by Christian Heimes in branch 'default':
Issue bpo-19682: Fix compatibility issue with old version of OpenSSL that
http://hg.python.org/cpython/rev/40bfddda43d4

@ronaldoussoren
Copy link
Contributor Author

That's quick... The patch fixes the issue for me as well.

Thanks!

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiran tiran

Labels
build The build process and cross-build extension-modules C modules in the Modules dir OS-mac
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiran @ronaldoussoren