Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty tests in pickletester need to be implemented or removed #63847

Closed
zware opened this issue Nov 19, 2013 · 7 comments
Closed

Empty tests in pickletester need to be implemented or removed #63847

zware opened this issue Nov 19, 2013 · 7 comments
Labels
easy tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@zware
Copy link
Member

zware commented Nov 19, 2013

BPO 19648
Nosy @pitrou, @avassalotti, @zware
Files
  • 19648.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-12-28.16:01:27.313>
created_at = <Date 2013-11-19.04:10:17.454>
labels = ['easy', 'type-feature', 'tests']
title = 'Empty tests in pickletester need to be implemented or removed'
updated_at = <Date 2013-12-28.16:01:27.311>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2013-12-28.16:01:27.311>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2013-12-28.16:01:27.313>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2013-11-19.04:10:17.454>
creator = 'zach.ware'
dependencies = []
files = ['33154']
hgrepos = []
issue_num = 19648
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['203338', '206259', '206633', '206829', '206911', '207034', '207035']
nosy_count = 5.0
nosy_names = ['pitrou', 'alexandre.vassalotti', 'python-dev', 'gennad', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19648'
versions = ['Python 3.4']
    @zware
    Copy link
    Member Author

    zware commented Nov 19, 2013

    There are a couple of tests in pickletester that should either be implemented or removed, namely test_reduce and test_getinitargs of AbstractPickleTests.

    I don't know enough about pickling to suggest which route should be taken or how, so I'll leave that up to anyone who wants to write a patch :)

    @zware zware added tests Tests in the Lib/test dir easy type-feature A feature request or enhancement labels Nov 19, 2013
    @gennad
    Copy link
    Mannequin

    gennad mannequin commented Dec 15, 2013

    Hi,

    I created 2 simple tests for test_getinitargs and test_reduce.

    @zware
    Copy link
    Member Author

    zware commented Dec 19, 2013

    The patch looks good to me, but I can't claim to know enough about pickle to say whether the tests are correct. Alexandre or Antoine?

    @pitrou
    Copy link
    Member

    pitrou commented Dec 22, 2013

    The patch looks fine to me. Gennadiy, could you go and sign a contributor's agreement? http://www.python.org/psf/contrib/
    Thanks very much.

    @gennad
    Copy link
    Mannequin

    gennad mannequin commented Dec 24, 2013

    Antoine, sure! I have just signed it. Thank you!

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 28, 2013

    New changeset fef075ddaec9 by Antoine Pitrou in branch 'default':
    Issue bpo-19648: implement empty tests in pickletester. Patch by Gennadiy Zlobin.
    http://hg.python.org/cpython/rev/fef075ddaec9

    @pitrou
    Copy link
    Member

    pitrou commented Dec 28, 2013

    I've pushed the patch. Thank you for your contribution!

    @pitrou pitrou closed this as completed Dec 28, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    easy tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @zware