Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_strftime.test_y_before_1900_nonwin() fails on AIX and Solaris #63833

Closed
vstinner opened this issue Nov 17, 2013 · 12 comments
Closed

test_strftime.test_y_before_1900_nonwin() fails on AIX and Solaris #63833

vstinner opened this issue Nov 17, 2013 · 12 comments
Labels
tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 19634
Nosy @pitrou, @vstinner, @tjguk

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-11-24.10:18:21.472>
created_at = <Date 2013-11-17.22:33:29.545>
labels = ['tests']
title = 'test_strftime.test_y_before_1900_nonwin() fails on AIX and Solaris'
updated_at = <Date 2013-11-24.10:18:21.471>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2013-11-24.10:18:21.471>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2013-11-24.10:18:21.472>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2013-11-17.22:33:29.545>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 19634
keywords = []
message_count = 12.0
messages = ['203218', '203219', '203220', '203242', '203253', '203261', '204020', '204021', '204023', '204046', '204053', '204192']
nosy_count = 5.0
nosy_names = ['pitrou', 'vstinner', 'tim.golden', 'python-dev', 'David.Edelsohn']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue19634'
versions = ['Python 3.4']
@vstinner
Copy link
Member Author

The isuse bpo-13674 added tests on strftime() for %y format with year < 1900 on Windows. It looks like AIX doesn't support them.

http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/1039/steps/test/logs/stdio

======================================================================
FAIL: test_y_before_1900_nonwin (test.test_strftime.Y1900Tests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-aix-ppc64/build/Lib/test/test_strftime.py", line 193, in test_y_before_1900_nonwin
    time.strftime("%y", (1899, 1, 1, 0, 0, 0, 0, 0, 0)), "99")
AssertionError: '0/' != '99'
- 0/
+ 99

@vstinner vstinner added the tests Tests in the Lib/test dir label Nov 17, 2013
@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 17, 2013

New changeset fd9ce1d4b820 by Victor Stinner in branch 'default':
Issue bpo-19634: time.strftime("%y") now raises a ValueError on AIX when given a
http://hg.python.org/cpython/rev/fd9ce1d4b820

@vstinner
Copy link
Member Author

I keep the issue open until the test succeed on AIX.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 18, 2013

New changeset 652de09a3a1a by Victor Stinner in branch 'default':
Issue bpo-19634: Fix time_strftime() on AIX, format is a wchar_t* not a PyObject*
http://hg.python.org/cpython/rev/652de09a3a1a

@vstinner
Copy link
Member Author

Ok, the test passed with the second fix.

@tjguk
Copy link
Member

tjguk commented Nov 18, 2013

Thanks, guys; I'm afraid I only watched the stable buildbots when I committed - the AIX doesn't seem to be included.

@vstinner
Copy link
Member Author

Oh, the test is failing with the same error on Solaris:

======================================================================
FAIL: test_y_before_1900 (test.test_strftime.Y1900Tests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/cpython/buildslave/cc-32/3.x.snakebite-solaris11-amd64/build/Lib/test/test_strftime.py", line 191, in test_y_before_1900
    self.assertEqual(time.strftime("%y", t), "99")
AssertionError: '0/' != '99'
- 0/
+ 99

@vstinner vstinner reopened this Nov 23, 2013
@vstinner vstinner changed the title test_strftime.test_y_before_1900_nonwin() fails on AIX test_strftime.test_y_before_1900_nonwin() fails on AIX and Solaris Nov 23, 2013
@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 23, 2013

New changeset b7fd5d8e9968 by Victor Stinner in branch 'default':
Issue bpo-19634: time.strftime("%y") now raises a ValueError on Solaris when given
http://hg.python.org/cpython/rev/b7fd5d8e9968

@vstinner
Copy link
Member Author

I leave the issue open until I see the test passing on Solaris.

@pitrou
Copy link
Member

pitrou commented Nov 23, 2013

This broke OpenIndiana:

======================================================================
ERROR: test_y_before_1900 (test.test_strftime.Y1900Tests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/test/test_strftime.py", line 191, in test_y_before_1900
    self.assertEqual(time.strftime("%y", t), "99")
ValueError: format %y requires year >= 1900 on AIX

@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 23, 2013

New changeset e73683514b4d by Victor Stinner in branch 'default':
Isue bpo-19634: test_y_before_1900() is expected to fail on Solaris
http://hg.python.org/cpython/rev/e73683514b4d

@vstinner
Copy link
Member Author

test_strftime now pass again on buildbots: OpenIndiana, Solaris, AIX.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @tjguk @pitrou