Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific asserts in test_asyncio #63788

Closed
serhiy-storchaka opened this issue Nov 14, 2013 · 4 comments
Closed

Use specific asserts in test_asyncio #63788

serhiy-storchaka opened this issue Nov 14, 2013 · 4 comments
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 19589
Nosy @gvanrossum, @serhiy-storchaka
Files
  • test_asyncio_asserts.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2013-11-14.21:13:45.691>
    created_at = <Date 2013-11-14.20:40:50.641>
    labels = ['type-feature', 'tests']
    title = 'Use specific asserts in test_asyncio'
    updated_at = <Date 2013-11-14.21:13:45.690>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-11-14.21:13:45.690>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2013-11-14.21:13:45.691>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2013-11-14.20:40:50.641>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['32618']
    hgrepos = []
    issue_num = 19589
    keywords = ['patch']
    message_count = 4.0
    messages = ['202880', '202882', '202889', '202892']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue19589'
    versions = ['Python 3.4']

    @serhiy-storchaka
    Copy link
    Member Author

    The proposed patch makes test_asyncio use more specific asserts. This will provide more useful failure report.

    @serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Nov 14, 2013
    @gvanrossum
    Copy link
    Member

    Looks good -- please commit.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 14, 2013

    New changeset 7e00bdada290 by Serhiy Storchaka in branch 'default':
    Issue bpo-19589: Use specific asserts in asyncio tests.
    http://hg.python.org/cpython/rev/7e00bdada290

    @serhiy-storchaka
    Copy link
    Member Author

    Done.

    @serhiy-storchaka serhiy-storchaka self-assigned this Nov 14, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants