Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all freebsd* host platforms #63753

Closed
william-gr mannequin opened this issue Nov 11, 2013 · 6 comments
Closed

Enable all freebsd* host platforms #63753

william-gr mannequin opened this issue Nov 11, 2013 · 6 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@william-gr
Copy link
Mannequin

william-gr mannequin commented Nov 11, 2013

BPO 19554
Nosy @malemburg, @zware, @koobs, @william-gr
Dependencies
  • bpo-12619: Automatically regenerate platform-specific modules
    		•
    Superseder
  • bpo-28027: Remove Lib/plat-/ files
    		•
    Files
  • tip.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-09-09.16:48:07.063>
created_at = <Date 2013-11-11.12:29:49.359>
labels = ['type-feature', 'build']
title = 'Enable all freebsd* host platforms'
updated_at = <Date 2016-09-09.16:48:07.061>
user = 'https://github.com/william-gr'

    bugs.python.org fields:

    activity = <Date 2016-09-09.16:48:07.061>
actor = 'zach.ware'
assignee = 'none'
closed = True
closed_date = <Date 2016-09-09.16:48:07.063>
closer = 'zach.ware'
components = ['Build']
creation = <Date 2013-11-11.12:29:49.359>
creator = 'wg'
dependencies = ['12619']
files = ['32574']
hgrepos = []
issue_num = 19554
keywords = ['patch']
message_count = 6.0
messages = ['202621', '202622', '202623', '202625', '202626', '275342']
nosy_count = 5.0
nosy_names = ['lemburg', 'Arfrever', 'zach.ware', 'koobs', 'wg']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = '28027'
type = 'enhancement'
url = 'https://bugs.python.org/issue19554'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
    @william-gr
    Copy link
    Mannequin Author

    william-gr mannequin commented Nov 11, 2013

    Hello,

    Currently python setup.py restricts FreeBSD host platform by version, e.g. freebsd7, freebsd8.

    It is not only out-of-date (we already are on freebsd11) but also doesn't seem to have a good reason to do so.

    Proposed patches replaces it with startswith('freebsd').

    Thanks

    @william-gr william-gr mannequin added build The build process and cross-build type-feature A feature request or enhancement labels Nov 11, 2013
    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Nov 11, 2013

    The comment says that semaphores are broken up to FreeBSD-8, so
    linking with -lrt is disabled. This looks correct to me and our
    FreeBSD 9 and 10 buildbots work.

    If you have a specific problem, please re-open the issue.

    @skrah skrah mannequin added the invalid label Nov 11, 2013
    @skrah skrah mannequin closed this as completed Nov 11, 2013
    @william-gr
    Copy link
    Mannequin Author

    william-gr mannequin commented Nov 11, 2013

    Semaphores broken or not (it seems to work just fine in freebsd9) python is still usable overall.

    I see no reason to arbitrarily chose what freebsd platform to build.

    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Nov 11, 2013

    I looked at patch set 1, which actually *reduced* functionality for FreeBSD >= 9.

    Now there is a second patch set, so I'm re-opening.

    @skrah skrah mannequin reopened this Nov 11, 2013
    @skrah skrah mannequin removed the invalid label Nov 11, 2013
    @william-gr
    Copy link
    Mannequin Author

    william-gr mannequin commented Nov 11, 2013

    Ah, I see, I made a misinterpretation of setup.py. Sorry about that.

    So please ignore the setup.py changes in the patch ;)

    @zware
    Copy link
    Member

    zware commented Sep 9, 2016

    The platform-specific modules have been removed.

    @zware zware closed this as completed Sep 9, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zware