Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 453: venv module and pyvenv integration #63751

Closed
ncoghlan opened this issue Nov 11, 2013 · 6 comments
Closed

PEP 453: venv module and pyvenv integration #63751

ncoghlan opened this issue Nov 11, 2013 · 6 comments
Assignees
@ncoghlan
Labels
release-blocker stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@ncoghlan
Copy link
Contributor

BPO 19552
Nosy @vsajip, @ncoghlan, @larryhastings, @ned-deily, @dstufft
Dependencies
  • bpo-19406: PEP 453: add the ensurepip module
    		•
    Files
  • issue19552_venv_module_api.diff: Module portion of the API, CLI changes still to come
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ncoghlan'
closed_at = <Date 2013-11-22.14:34:27.801>
created_at = <Date 2013-11-11.10:46:02.397>
labels = ['type-feature', 'library', 'release-blocker']
title = 'PEP 453: venv module and pyvenv integration'
updated_at = <Date 2014-03-09.22:50:25.608>
user = 'https://github.com/ncoghlan'

    bugs.python.org fields:

    activity = <Date 2014-03-09.22:50:25.608>
actor = 'python-dev'
assignee = 'ncoghlan'
closed = True
closed_date = <Date 2013-11-22.14:34:27.801>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2013-11-11.10:46:02.397>
creator = 'ncoghlan'
dependencies = ['19406']
files = ['32775']
hgrepos = []
issue_num = 19552
keywords = ['patch']
message_count = 6.0
messages = ['202612', '203759', '203760', '203769', '203780', '212997']
nosy_count = 6.0
nosy_names = ['vinay.sajip', 'ncoghlan', 'larry', 'ned.deily', 'python-dev', 'dstufft']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19552'
versions = ['Python 3.4']
    @ncoghlan
    Copy link
    Contributor Author

    Part of the PEP-453 implementation as tracked in bpo-19347.

    This issue covers the venv module and pyvenv CLI updates:

    • Add a "with_pip=False" parameter to venv.EnvBuilder and venv.create

    • When with_pip is a true value, invoke ensurepip.bootstrap with the root set to the just created venv and default_pip set to True

    • update pyvenv to pass with_pip=True by default

    • add a --without-pip option to pyvenv to pass with_pip=False instead

    @ncoghlan ncoghlan added release-blocker type-feature A feature request or enhancement stdlib Python modules in the Lib dir labels Nov 11, 2013
    @ncoghlan ncoghlan self-assigned this Nov 15, 2013
    @ncoghlan
    Copy link
    Contributor Author

    Since ensurepip needs to manipulate sys.path, I ended up running the "-m ensurepip" using the venv Python in a subprocess. This both avoids side effects on the current process and gets ensurepip the right target directory settings automatically.

    @dstufft
    Copy link
    Member

    dstufft commented Nov 22, 2013

    That's similar to how virtualenv does it, so it's probably pretty reasonable.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 22, 2013

    New changeset 57fbab22ab4e by Nick Coghlan in branch 'default':
    Close bpo-19552: venv and pyvenv ensurepip integration
    http://hg.python.org/cpython/rev/57fbab22ab4e

    @python-dev python-dev mannequin closed this as completed Nov 22, 2013
    @ncoghlan
    Copy link
    Contributor Author

    Rather than reopening this (which is part of tracking the feature integration for the beta), I opened bpo-19694 to cover the stable buildbot that is objecting to the new venv test (most of the others seem happy with it)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 9, 2014

    New changeset a140caad76bc by R David Murray in branch 'default':
    whatsnew: venv with_pip, pyvenv --without-pip (bpo-19552)
    http://hg.python.org/cpython/rev/a140caad76bc

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ncoghlan ncoghlan

    Labels
    release-blocker stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @dstufft @ncoghlan