Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report skipped distutils tests as skipped #63691

Closed
serhiy-storchaka opened this issue Nov 4, 2013 · 8 comments
Closed

Report skipped distutils tests as skipped #63691

serhiy-storchaka opened this issue Nov 4, 2013 · 8 comments
Assignees
@serhiy-storchaka
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 19492
Nosy @tarekziade, @merwok, @zware, @serhiy-storchaka, @vajrasky
Files
  • skip_tests_distutils.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-12-18.14:50:37.324>
created_at = <Date 2013-11-04.12:57:44.902>
labels = ['tests', 'type-feature', 'library']
title = 'Report skipped distutils tests as skipped'
updated_at = <Date 2013-12-18.14:50:37.323>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-12-18.14:50:37.323>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-12-18.14:50:37.324>
closer = 'serhiy.storchaka'
components = ['Distutils', 'Tests']
creation = <Date 2013-11-04.12:57:44.902>
creator = 'serhiy.storchaka'
dependencies = []
files = ['32498']
hgrepos = []
issue_num = 19492
keywords = ['patch']
message_count = 8.0
messages = ['202123', '202128', '202136', '202148', '206203', '206496', '206522', '206523']
nosy_count = 7.0
nosy_names = ['tarek', 'eric.araujo', 'Arfrever', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19492'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
    @serhiy-storchaka
    Copy link
    Member Author

    Some skipped distutils tests are reported as passed. Arfrever pointed out on some of these tests on IRC. Proposed patch adds explicit reporting them as skipped.

    See also bpo-18702.

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Nov 4, 2013
    @vajrasky
    Copy link
    Mannequin

    vajrasky mannequin commented Nov 4, 2013

    You forgot to upload the "proposed patch", Serhiy.

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you Vajrasky.

    @Arfrever
    Copy link
    Mannequin

    Arfrever mannequin commented Nov 4, 2013

    Lib/distutils/tests/test_build_ext.py
    ...

    •        ALREADY_TESTED = True

    •        ALREADY_TESTED = type(self).\_\_name__

    Why this change?

    Lib/distutils/tests/test_build_ext.py
    ...

    • @unittest.skipIf(sys.version < '2.6',
    •                 'site.USER_SITE was introduced in 2.6')
      def test_user_site(self):
    •    # site.USER_SITE was introduced in 2.6

    •    if sys.version \< '2.6':

    •        return

    This check probably could be deleted.

    @serhiy-storchaka
    Copy link
    Member Author

    Why this change?

    For better skip message (see a change above).

    @merwok
    Copy link
    Member

    merwok commented Dec 18, 2013

    Alright. Patch looks good, thanks.

    @merwok merwok assigned serhiy-storchaka and unassigned merwok Dec 18, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 18, 2013

    New changeset b3f3e6afe966 by Serhiy Storchaka in branch '3.3':
    Issue bpo-19492: Silently skipped distutils tests now reported as skipped.
    http://hg.python.org/cpython/rev/b3f3e6afe966

    New changeset da3472687566 by Serhiy Storchaka in branch 'default':
    Issue bpo-19492: Silently skipped distutils tests now reported as skipped.
    http://hg.python.org/cpython/rev/da3472687566

    New changeset d5b0bb2a1790 by Serhiy Storchaka in branch '2.7':
    Issue bpo-19492: Silently skipped distutils tests now reported as skipped.
    http://hg.python.org/cpython/rev/d5b0bb2a1790

    @serhiy-storchaka
    Copy link
    Member Author

    Thanks Arfrever, Zachary and Éric for reviews.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @merwok @serhiy-storchaka