Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate site-python in site.py #63574

Closed
pitrou opened this issue Oct 24, 2013 · 4 comments
Closed

Deprecate site-python in site.py #63574

pitrou opened this issue Oct 24, 2013 · 4 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@pitrou
Copy link
Member

pitrou commented Oct 24, 2013

BPO 19375
Nosy @loewis, @warsaw, @pitrou, @vstinner, @tiran
Files
  • deprecate_site_python.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-10-25.19:40:36.236>
created_at = <Date 2013-10-24.09:11:11.237>
labels = ['type-feature', 'library']
title = 'Deprecate site-python in site.py'
updated_at = <Date 2013-10-25.19:40:36.235>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2013-10-25.19:40:36.235>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2013-10-25.19:40:36.236>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2013-10-24.09:11:11.237>
creator = 'pitrou'
dependencies = []
files = ['32342']
hgrepos = []
issue_num = 19375
keywords = ['patch']
message_count = 4.0
messages = ['201103', '201104', '201180', '201282']
nosy_count = 6.0
nosy_names = ['loewis', 'barry', 'pitrou', 'vstinner', 'christian.heimes', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19375'
versions = ['Python 3.4']
    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 24, 2013

    I suggest deprecating the "site-python" feature from site.py, as proposed by Guido on python-dev:
    https://mail.python.org/pipermail/python-dev/2013-October/129820.html

    • if a "site-python" directory is detected and added from site.py, a DeprecationWarning should be emitted
    • the site.py docs should mention the deprecation

    @pitrou pitrou added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 24, 2013
    @vstinner
    Copy link
    Member

    Guido wrote "I suggest that we remove that feature. (People who want it can always patch up their own $PYTHONPATH.)". It's different than deprecating the feature :-)

    I didn't know the feature before you proposed to remove it. Is the site-python thing used in the wild? I never see any OS relying on it.

    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 24, 2013

    Here is a patch.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 25, 2013

    New changeset 90c56229efb7 by Antoine Pitrou in branch 'default':
    Issue bpo-19375: The site module adding a "site-python" directory to sys.path, if it exists, is now deprecated.
    http://hg.python.org/cpython/rev/90c56229efb7

    @pitrou pitrou closed this as completed Oct 25, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @pitrou