Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 453 implementation tracking issue #63546

Closed
ncoghlan opened this issue Oct 22, 2013 · 18 comments
Closed

PEP 453 implementation tracking issue #63546

ncoghlan opened this issue Oct 22, 2013 · 18 comments
Assignees
Labels
type-feature A feature request or enhancement

Comments

@ncoghlan
Copy link
Contributor

BPO 19347
Nosy @loewis, @vsajip, @ncoghlan, @larryhastings, @ned-deily, @dstufft
Dependencies
  • bpo-19406: PEP 453: add the ensurepip module
  • bpo-19550: PEP 453: Windows installer integration
  • bpo-19551: PEP 453: Mac OS X installer integration
  • bpo-19552: PEP 453: venv module and pyvenv integration
  • bpo-19553: PEP 453: "make install" and "make altinstall" integration
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ncoghlan'
    closed_at = <Date 2014-01-03.05:20:09.279>
    created_at = <Date 2013-10-22.11:48:34.772>
    labels = ['type-feature']
    title = 'PEP 453 implementation tracking issue'
    updated_at = <Date 2014-01-03.05:20:09.277>
    user = 'https://github.com/ncoghlan'

    bugs.python.org fields:

    activity = <Date 2014-01-03.05:20:09.277>
    actor = 'ncoghlan'
    assignee = 'ncoghlan'
    closed = True
    closed_date = <Date 2014-01-03.05:20:09.279>
    closer = 'ncoghlan'
    components = []
    creation = <Date 2013-10-22.11:48:34.772>
    creator = 'ncoghlan'
    dependencies = ['19406', '19550', '19551', '19552', '19553']
    files = []
    hgrepos = []
    issue_num = 19347
    keywords = []
    message_count = 18.0
    messages = ['200923', '200925', '200945', '200950', '200956', '201345', '202617', '203772', '203779', '203950', '204169', '204294', '205109', '205110', '206845', '207174', '207200', '207205']
    nosy_count = 8.0
    nosy_names = ['loewis', 'vinay.sajip', 'ncoghlan', 'larry', 'ned.deily', 'tshepang', 'bkabrda', 'dstufft']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue19347'
    versions = ['Python 3.4']

    @ncoghlan
    Copy link
    Contributor Author

    This is the overall tracking issue for the implementation of PEP-453. The following subtasks will be created as separate issues:

    • update the Installing Python Modules documentation to reference www.pip-installer.org in Python 2.7, 3.3 and 3.4 (ncoghlan)
    • initial implementation of ensurepip (dstufft)
    • Python 3.4 documentation updates for ensurepip (dstufft and/or ncoghlan)
    • Windows installer updates, including PATH manipulation updates (MvL?)
    • Mac OS X installer updates (Ned?)
    • venv and pyvenv updates (dstufft? TBC)

    @ncoghlan ncoghlan self-assigned this Oct 22, 2013
    @ncoghlan ncoghlan added the type-feature A feature request or enhancement label Oct 22, 2013
    @ncoghlan
    Copy link
    Contributor Author

    One more task to track - updating to the latest upstream pip before beta 2.

    @vsajip
    Copy link
    Member

    vsajip commented Oct 22, 2013

    venv shouldn't need any changes. The pyvenvex.py [1] script I posted to distutils-sig installs setuptools and pip into venvs, and it can be used to update pyvenv (where AFAICT changes are only required to change where the pip to be installed comes from).

    [1] https://gist.github.com/vsajip/4673395

    @ncoghlan
    Copy link
    Contributor Author

    Check PEP-453 again: http://www.python.org/dev/peps/pep-0453/#changes-to-virtual-environments

    Rather than only changing pyvenv, the API in the PEP is to add "with_pip" parameters to the venv module API, so that anyone building pyvenv style tools on top of venv can easily request installation of pip by passing "with_pip=True". The change to pyvenv is then to just add the --without-pip flag (since the default is inverted for the two interfaces - library API is opt-in for backwards compatibility, tool CLI is opt-out)

    @ncoghlan
    Copy link
    Contributor Author

    Just clarifying how I plan to track this: as we start specific tasks, we'll
    create new issues and make this one depend on them. That seems better to me
    than creating a whole raft of issues up front that are then depending on
    each other.

    @ncoghlan
    Copy link
    Contributor Author

    First two working issues created:

    bpo-19406 for the addition of ensurepip and its docs
    bpo-19407 for the Installing Python Modules updates

    @ncoghlan
    Copy link
    Contributor Author

    New subtasks:

    bpo-19550: Windows installer integration
    bpo-19551: Mac OS X installer integration
    bpo-19552: venv module and pyvenv integration
    bpo-19553: "make install" and "make altinstall" integration open

    @ncoghlan
    Copy link
    Contributor Author

    bpo-19693 covers an anomaly where "make altinstall && make install" doesn't quite do the same thing as "make install" (the "pip3" script will be missing in the former case)

    @ncoghlan
    Copy link
    Contributor Author

    bpo-19694 is a new issue for one of the buildbots objecting to the new venv tests.

    @ncoghlan
    Copy link
    Contributor Author

    Created bpo-19728 to track what is needed before the installation of pip can be made the default in the installers (at least for Windows, but I assume MvL's concerns would apply equally to the Mac OS X installer)

    @ncoghlan
    Copy link
    Contributor Author

    bpo-19744 covers better handling of the case where SSL/TLS support is not available in the current Python.

    @ncoghlan
    Copy link
    Contributor Author

    bpo-19734 covers the fact that pip environment variable settings impact venv and ensurepip

    @ncoghlan
    Copy link
    Contributor Author

    ncoghlan commented Dec 3, 2013

    bpo-19766 covers the fact that the vendored urllib3 needs to be updated in order to handle the case where Python is built without threading support.

    @ncoghlan
    Copy link
    Contributor Author

    ncoghlan commented Dec 3, 2013

    Upgrading to release blocker status, since we'd prefer to have everything we can sorted before beta 2

    @ncoghlan
    Copy link
    Contributor Author

    bpo-20053 covers the fact that the default pip config file affects ensurepip and venv.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jan 2, 2014

    I propose to downgrade this from "release blocker" again. "prefer to have everything we can sorted" is IMO not a sufficient rationale to block the release; if taken literally, 3.4 could never ever release since it doesn't have everything sorted out that I would personally want to sort out some time in Python.

    If individual subissues should block the release, the should be promoted.

    @ncoghlan
    Copy link
    Contributor Author

    ncoghlan commented Jan 3, 2014

    Agreed, it was mostly to ensure we reviewed the status to make sure we were
    happy with progress. The only remaining "must fix" item is the docs update,
    and that's shouldn't block beta 2 (although I'll still try to get at least
    an initial version done now that pip 1.5 is released).

    @loewis loewis mannequin removed the release-blocker label Jan 3, 2014
    @ncoghlan
    Copy link
    Contributor Author

    ncoghlan commented Jan 3, 2014

    Actually, with the docs update being the only remaining "this really should be done before 3.4 is released" issue related to PEP-453, I think this tracking issue has now served its purpose.

    So, closing this umbrella issue now, since bpo-19407 covers the docs update.

    Thanks again to everyone that contributed the various bits and pieces needed to make the PEP a reality :)

    @ncoghlan ncoghlan closed this as completed Jan 3, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants