Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sporadic test_asyncio failure under FreeBSD #63504

Closed
pitrou opened this issue Oct 19, 2013 · 8 comments
Closed

sporadic test_asyncio failure under FreeBSD #63504

pitrou opened this issue Oct 19, 2013 · 8 comments
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Oct 19, 2013

BPO 19305
Nosy @gvanrossum, @pitrou, @koobs
Files
  • asyncio_wait_for.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-10-20.00:00:08.535>
created_at = <Date 2013-10-19.23:18:45.599>
labels = ['tests', 'type-bug', 'library']
title = 'sporadic test_asyncio failure under FreeBSD'
updated_at = <Date 2013-10-20.03:07:34.239>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2013-10-20.03:07:34.239>
actor = 'koobs'
assignee = 'none'
closed = True
closed_date = <Date 2013-10-20.00:00:08.535>
closer = 'pitrou'
components = ['Library (Lib)', 'Tests']
creation = <Date 2013-10-19.23:18:45.599>
creator = 'pitrou'
dependencies = []
files = ['32233']
hgrepos = []
issue_num = 19305
keywords = ['patch', 'buildbot']
message_count = 8.0
messages = ['200515', '200517', '200519', '200522', '200523', '200524', '200526', '200535']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'pitrou', 'python-dev', 'koobs']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19305'
versions = ['Python 3.4']
    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 19, 2013

    http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/626/steps/test/logs/stdio

    ======================================================================
    FAIL: test_create_server (test.test_asyncio.test_events.SelectEventLoopTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/test_asyncio/test_events.py", line 568, in test_create_server
    self.assertEqual(3, proto.nbytes)
AssertionError: 3 != 0

    @pitrou pitrou added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 19, 2013
    @gvanrossum
    Copy link
    Member

    I'm guessing there's a whole lot of tests calling run_briefly() that really need to be fixed along these lines:

    http://code.google.com/p/tulip/source/detail?r=44e4c8257a9d

    I'd like to add a new method to test_utils.py for that purpose. But if at all possible I'd like to do that post alpha release.

    @gvanrossum gvanrossum self-assigned this Oct 19, 2013
    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 19, 2013

    How about the following?
    I was a bit annoyed I had to pass the loop explicitly to task.sleep().

    @gvanrossum
    Copy link
    Member

    That patch looks good except please don't call it wait_for(), since there's already tasks.wait_for(). You can call it run_until().

    Having to pass the loop to sleep() is only really required in the tests -- there was a movement a while ago (started by Alex Gaynor and supported by Glyph) to always pass in an explicit loop; my compromise was to force the tests to always pass in a loop (by using set_event_loop(None)).

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 19, 2013

    New changeset f1447c152fb7 by Antoine Pitrou in branch 'default':
    Issue bpo-19305: try to fix sporadic test_asyncio failure on FreeBSD 10.0
    http://hg.python.org/cpython/rev/f1447c152fb7

    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 19, 2013

    Ok, I called it run_until. Hopefully this will manage to appease the buildbot.

    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 20, 2013

    Looks ok on the buildbot.

    @pitrou pitrou closed this as completed Oct 20, 2013
    @koobs
    Copy link

    koobs commented Oct 20, 2013

    You rock Antoine.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @koobs @pitrou @gvanrossum