Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_wave failing on PPC64 Linux #63475

Closed
DavidEdelsohn mannequin opened this issue Oct 17, 2013 · 11 comments
Closed

test_wave failing on PPC64 Linux #63475

DavidEdelsohn mannequin opened this issue Oct 17, 2013 · 11 comments
Assignees
@serhiy-storchaka
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@DavidEdelsohn
Copy link
Mannequin

DavidEdelsohn mannequin commented Oct 17, 2013

BPO 19276
Nosy @pitrou, @serhiy-storchaka
Files
  • wave_ppc64.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-10-17.22:56:08.338>
created_at = <Date 2013-10-17.03:38:02.162>
labels = ['tests', 'type-bug', 'library']
title = 'test_wave failing on PPC64 Linux'
updated_at = <Date 2013-10-18.15:26:51.680>
user = 'https://bugs.python.org/DavidEdelsohn'

    bugs.python.org fields:

    activity = <Date 2013-10-18.15:26:51.680>
actor = 'David.Edelsohn'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-10-17.22:56:08.338>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'Tests']
creation = <Date 2013-10-17.03:38:02.162>
creator = 'David.Edelsohn'
dependencies = []
files = ['32157']
hgrepos = []
issue_num = 19276
keywords = ['patch']
message_count = 11.0
messages = ['200116', '200127', '200130', '200153', '200155', '200158', '200160', '200162', '200164', '200173', '200273']
nosy_count = 4.0
nosy_names = ['pitrou', 'python-dev', 'serhiy.storchaka', 'David.Edelsohn']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19276'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
    @DavidEdelsohn DavidEdelsohn mannequin added extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Oct 17, 2013
    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir and removed extension-modules C modules in the Modules dir labels Oct 17, 2013
    @serhiy-storchaka serhiy-storchaka self-assigned this Oct 17, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 17, 2013

    New changeset 73dad296c483 by Serhiy Storchaka in branch '2.7':
    bpo-19276: Fix tests for wave files on big-endian platforms.
    http://hg.python.org/cpython/rev/73dad296c483

    New changeset 236884b40a2d by Serhiy Storchaka in branch '3.3':
    bpo-19276: Fix tests for wave files on big-endian platforms.
    http://hg.python.org/cpython/rev/236884b40a2d

    New changeset 8bdf5328c55b by Serhiy Storchaka in branch 'default':
    bpo-19276: Fix tests for wave files on big-endian platforms.
    http://hg.python.org/cpython/rev/8bdf5328c55b

    @DavidEdelsohn
    Copy link
    Mannequin Author

    DavidEdelsohn mannequin commented Oct 17, 2013

    The patch does not appear to fix the tests for wave on big-endian PPC64 Linux.

    @serhiy-storchaka
    Copy link
    Member

    It fixed a bug in wave tests, but not a bug in the wave module. I'm working on this.

    @serhiy-storchaka
    Copy link
    Member

    What are array.array('l').itemsize and array.array('i').itemsize on PPC64 Linux?

    I suppose that this patch should fix the wave module on 64-bit platforms.

    @DavidEdelsohn
    Copy link
    Mannequin Author

    DavidEdelsohn mannequin commented Oct 17, 2013 

    >>> import array
>>> print array.array('l').itemsize
8
>>> print array.array('i').itemsize
4

    @serhiy-storchaka
    Copy link
    Member

    Thank you David. I suspected this.

    @pitrou
    Copy link
    Member

    pitrou commented Oct 17, 2013

    For the record, why would this patch fix the issue? test_wave works fine under other 64-bit platforms.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 17, 2013

    New changeset 9d2605f24a86 by Serhiy Storchaka in branch '2.7':
    Issue bpo-19276: Fixed the wave module on 64-bit big-endian platforms.
    http://hg.python.org/cpython/rev/9d2605f24a86

    New changeset a1a4a527c699 by Serhiy Storchaka in branch '3.3':
    Issue bpo-19276: Fixed the wave module on 64-bit big-endian platforms.
    http://hg.python.org/cpython/rev/a1a4a527c699

    New changeset 7e8ad3084891 by Serhiy Storchaka in branch 'default':
    Issue bpo-19276: Fixed the wave module on 64-bit big-endian platforms.
    http://hg.python.org/cpython/rev/7e8ad3084891

    @serhiy-storchaka
    Copy link
    Member

    Perhaps other 64-bit platforms are little-endian?

    @serhiy-storchaka
    Copy link
    Member

    Fixed. Thank you David for your report.

    @DavidEdelsohn
    Copy link
    Mannequin Author

    DavidEdelsohn mannequin commented Oct 18, 2013

    Thanks!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @serhiy-storchaka