Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'x' mode to bz2.open() #63422

Closed
oylenshpeegul mannequin opened this issue Oct 10, 2013 · 4 comments
Closed

Add 'x' mode to bz2.open() #63422

oylenshpeegul mannequin opened this issue Oct 10, 2013 · 4 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@oylenshpeegul
Copy link
Mannequin

oylenshpeegul mannequin commented Oct 10, 2013

BPO 19223
Nosy @vajrasky
Files
  • patch.bz2.py: Patch to allow option 'x' for the mode.
  • add_x_mode_to_bz2.patch: Added test to Tim Heaney's work
  • add_x_mode_to_bz2_v2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-10-18.22:12:46.039>
created_at = <Date 2013-10-10.21:34:35.590>
labels = ['type-feature', 'library']
title = "Add 'x' mode to bz2.open()"
updated_at = <Date 2013-10-18.22:12:46.038>
user = 'https://bugs.python.org/oylenshpeegul'

    bugs.python.org fields:

    activity = <Date 2013-10-18.22:12:46.038>
actor = 'nadeem.vawda'
assignee = 'nadeem.vawda'
closed = True
closed_date = <Date 2013-10-18.22:12:46.039>
closer = 'nadeem.vawda'
components = ['Library (Lib)']
creation = <Date 2013-10-10.21:34:35.590>
creator = 'oylenshpeegul'
dependencies = []
files = ['32040', '32074', '32075']
hgrepos = []
issue_num = 19223
keywords = ['patch']
message_count = 4.0
messages = ['199418', '199655', '199658', '200313']
nosy_count = 5.0
nosy_names = ['nadeem.vawda', 'Arfrever', 'python-dev', 'vajrasky', 'oylenshpeegul']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19223'
versions = ['Python 3.4']
    @oylenshpeegul
    Copy link
    Mannequin Author

    oylenshpeegul mannequin commented Oct 10, 2013

    This is analogous to bpo-19201, but for bz2. Recent versions of Python have an 'x' mode for open, but bz2 doesn't support it. It looks like everything is passed to builtins.open eventually, so if we just allow the 'x' option to pass through, all will be well.

    @oylenshpeegul oylenshpeegul mannequin added the type-feature A feature request or enhancement label Oct 10, 2013
    @Arfrever Arfrever mannequin added the stdlib Python modules in the Lib dir label Oct 12, 2013
    @Arfrever Arfrever mannequin changed the title bz2 and 'x' mode open Add 'x' mode to bz2.open() Oct 12, 2013
    @vajrasky
    Copy link
    Mannequin

    vajrasky mannequin commented Oct 13, 2013

    Added test.

    @vajrasky
    Copy link
    Mannequin

    vajrasky mannequin commented Oct 13, 2013

    Added doc.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 18, 2013

    New changeset 5abc04e6579b by Nadeem Vawda in branch 'default':
    Issue bpo-19223: Add support for the 'x' mode to the bz2 module.
    http://hg.python.org/cpython/rev/5abc04e6579b

    @nadeemvawda nadeemvawda mannequin closed this as completed Oct 18, 2013
    @nadeemvawda nadeemvawda mannequin self-assigned this Oct 18, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    0 participants