Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtensionFileLoader missing get_filename() #63351

Closed
ericsnowcurrently opened this issue Oct 3, 2013 · 12 comments
Closed

ExtensionFileLoader missing get_filename() #63351

ericsnowcurrently opened this issue Oct 3, 2013 · 12 comments
Assignees
@ericsnowcurrently
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

BPO 19152
Nosy @brettcannon, @ericsnowcurrently, @berkerpeksag

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2013-10-05.02:40:32.985>
created_at = <Date 2013-10-03.07:01:35.317>
labels = ['interpreter-core', 'type-bug']
title = 'ExtensionFileLoader missing get_filename()'
updated_at = <Date 2013-10-05.02:40:32.984>
user = 'https://github.com/ericsnowcurrently'

bugs.python.org fields:

activity = <Date 2013-10-05.02:40:32.984>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2013-10-05.02:40:32.985>
closer = 'eric.snow'
components = ['Interpreter Core']
creation = <Date 2013-10-03.07:01:35.317>
creator = 'eric.snow'
dependencies = []
files = []
hgrepos = []
issue_num = 19152
keywords = []
message_count = 12.0
messages = ['198886', '198896', '198906', '198907', '198914', '198917', '198918', '198919', '198920', '198921', '198926', '198978']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'python-dev', 'eric.snow', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19152'
versions = ['Python 3.4']
@ericsnowcurrently
Copy link
Member Author

Any reason why ExtensionFileLoader does not implement get_filename()? I'm guessing it just slipped through the cracks. It should be there (and be registered as implementing ExecutionLoader).

@ericsnowcurrently ericsnowcurrently self-assigned this Oct 3, 2013
@ericsnowcurrently ericsnowcurrently added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Oct 3, 2013
@brettcannon
Copy link
Member

Just an oversight.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 3, 2013

New changeset 0d079c66dc23 by Eric Snow in branch 'default':
[bpo-19152] Add ExtensionFileLoader.get_filename().
http://hg.python.org/cpython/rev/0d079c66dc23

@ericsnowcurrently
Copy link
Member Author

I realized after I committed that this should probably be back-ported to 3.3. I'll take care of that in a few hours.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 3, 2013

New changeset 832579dbafd6 by Eric Snow in branch '3.3':
[bpo-19152] Add ExtensionFileLoader.get_filename().
http://hg.python.org/cpython/rev/832579dbafd6

@brettcannon
Copy link
Member

Actually you need to back out the 3.3 commit. That's a new API in a bugfix release and that's bad.

@brettcannon brettcannon reopened this Oct 3, 2013
@ericsnowcurrently
Copy link
Member Author

Dang it. I was thinking of it as a bug that the method wasn't there, but you're right regardless. Revert coming.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 3, 2013

New changeset 7ed717bd5faa by Eric Snow in branch '3.3':
[bpo-19152] Revert 832579dbafd6.
http://hg.python.org/cpython/rev/7ed717bd5faa

@ericsnowcurrently
Copy link
Member Author

Thanks for noticing that, Brett.

@berkerpeksag
Copy link
Member

It would be good to add a versionadded(or versionchanged) tag.

@ericsnowcurrently
Copy link
Member Author

Good point.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Oct 5, 2013

New changeset 62d045a873bb by Eric Snow in branch 'default':
[bpo-19152] Ensure we have actually registered ExtensionFileLoader as an ExecutionLoader.
http://hg.python.org/cpython/rev/62d045a873bb

New changeset e9554199620f by Eric Snow in branch 'default':
[bpo-19152] Add versionadded for ExtensionFileLoader.get_filename().
http://hg.python.org/cpython/rev/e9554199620f

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@berkerpeksag @brettcannon @ericsnowcurrently