Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use argparse in the calendar module #63173

Closed
serhiy-storchaka opened this issue Sep 8, 2013 · 9 comments
Closed

Use argparse in the calendar module #63173

serhiy-storchaka opened this issue Sep 8, 2013 · 9 comments
Assignees
@serhiy-storchaka
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 18973
Nosy @rhettinger, @bitdancer, @serhiy-storchaka, @matrixise, @vajrasky
Dependencies
  • bpo-18982: Add tests for CLI of the calendar module
    		•
    Files
  • calendar_argparse.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-11-01.15:17:33.321>
created_at = <Date 2013-09-08.15:06:16.295>
labels = ['type-feature', 'library']
title = 'Use argparse in the calendar module'
updated_at = <Date 2015-11-01.15:18:40.918>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2015-11-01.15:18:40.918>
actor = 'matrixise'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-11-01.15:17:33.321>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2013-09-08.15:06:16.295>
creator = 'serhiy.storchaka'
dependencies = ['18982']
files = ['31670']
hgrepos = []
issue_num = 18973
keywords = ['patch']
message_count = 9.0
messages = ['197264', '197268', '197270', '197301', '197321', '253628', '253852', '253853', '253854']
nosy_count = 7.0
nosy_names = ['rhettinger', 'bethard', 'r.david.murray', 'python-dev', 'serhiy.storchaka', 'matrixise', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18973'
versions = ['Python 3.6']
    @serhiy-storchaka
    Copy link
    Member Author

    Here is a patch which replaces optparse to argparse in the calendar modules.

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Sep 8, 2013
    @vajrasky
    Copy link
    Mannequin

    vajrasky mannequin commented Sep 8, 2013

    I don't see any patches. You forgot to upload the patch?

    @serhiy-storchaka
    Copy link
    Member Author

    You forgot to upload the patch?

    Again.

    @bitdancer
    Copy link
    Member

    I think it is highly inadvisable to make changes like this without also adding tests. We broke compileall by doing this even though we *did* add tests.

    @serhiy-storchaka
    Copy link
    Member Author

    Good point. See bpo-18982.

    @matrixise
    Copy link
    Member

    Hi Serhiy,

    I just reviewed your patch, works fine with 3.6.

    @serhiy-storchaka serhiy-storchaka self-assigned this Nov 1, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 1, 2015

    New changeset 9f8b5053e30d by Serhiy Storchaka in branch 'default':
    Issue bpo-18973: Command-line interface of the calendar module now uses argparse
    https://hg.python.org/cpython/rev/9f8b5053e30d

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you SilentGhost and Stéphane for your review.

    @matrixise
    Copy link
    Member

    Serhiy, welcome.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @matrixise @bitdancer @serhiy-storchaka