Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name attribute for HMAC #62975

Closed
tiran opened this issue Aug 18, 2013 · 4 comments
Closed

name attribute for HMAC #62975

tiran opened this issue Aug 18, 2013 · 4 comments
Assignees
@tiran
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Aug 18, 2013

BPO 18775
Nosy @gpshead, @jaraco, @tiran
Files
  • hmac_name.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2013-11-20.16:37:19.241>
created_at = <Date 2013-08-18.16:35:57.129>
labels = ['type-feature', 'library']
title = 'name attribute for HMAC'
updated_at = <Date 2014-03-09.19:17:40.313>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2014-03-09.19:17:40.313>
actor = 'python-dev'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2013-11-20.16:37:19.241>
closer = 'christian.heimes'
components = ['Library (Lib)']
creation = <Date 2013-08-18.16:35:57.129>
creator = 'christian.heimes'
dependencies = []
files = ['31360']
hgrepos = []
issue_num = 18775
keywords = ['patch']
message_count = 4.0
messages = ['195570', '200730', '203501', '212971']
nosy_count = 4.0
nosy_names = ['gregory.p.smith', 'jaraco', 'christian.heimes', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18775'
versions = ['Python 3.4']
    @tiran
    Copy link
    Member Author

    tiran commented Aug 18, 2013

    In issue bpo-18532 name attribute was officially documented and tested for hashing objects. PEP-247 considers HMAC as keyed hashing algorithm. Therefore I suggest that HMAC object should provide the same interface.

    It's a bit unfortunate that HMAC has a blocksize attribute for the default blocksize but the API defines a block_size attribute.

    @tiran tiran added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Aug 18, 2013
    @tiran
    Copy link
    Member Author

    tiran commented Oct 21, 2013

    I'm going to commit the patch this week. Speak now or forever hold your peace...

    @tiran tiran self-assigned this Nov 17, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 20, 2013

    New changeset 71f4a805d262 by Christian Heimes in branch 'default':
    Issue bpo-18775: Add name and block_size attribute to HMAC object. They now
    http://hg.python.org/cpython/rev/71f4a805d262

    @tiran tiran closed this as completed Nov 20, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 9, 2014

    New changeset dde3fb877b07 by R David Murray in branch 'default':
    whatsnew: hmac conforms to PEP-247. (bpo-18775)
    http://hg.python.org/cpython/rev/dde3fb877b07

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran