Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBKDF2 support #62782

Closed
tiran opened this issue Jul 28, 2013 · 12 comments
Closed

PBKDF2 support #62782

tiran opened this issue Jul 28, 2013 · 12 comments
Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Jul 28, 2013

BPO 18582
Nosy @pitrou, @tiran, @dstufft
Files
  • pbkdf2_3.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-10-12.23:16:20.948>
created_at = <Date 2013-07-28.15:11:19.332>
labels = ['extension-modules', 'type-feature']
title = 'PBKDF2 support'
updated_at = <Date 2013-11-06.16:25:33.175>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2013-11-06.16:25:33.175>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2013-10-12.23:16:20.948>
closer = 'christian.heimes'
components = ['Extension Modules']
creation = <Date 2013-07-28.15:11:19.332>
creator = 'christian.heimes'
dependencies = []
files = ['32071']
hgrepos = []
issue_num = 18582
keywords = ['patch']
message_count = 12.0
messages = ['193832', '193835', '199601', '199626', '199628', '199630', '199636', '199641', '200410', '200429', '200451', '202272']
nosy_count = 4.0
nosy_names = ['pitrou', 'christian.heimes', 'python-dev', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18582'
versions = ['Python 3.4']
    @tiran
    Copy link
    Member Author

    tiran commented Jul 28, 2013

    The patch is a proof of concept for PBKDF2 support for the OpenSSL variant of hashlib. It's a thin wrapper around PKCS5_PBKDF2_HMAC() and is deliberately designed as low level API with bytes and input and output types. High level wrappers can do the conversation and choose sensible values for salt, iterations and key length.

    @tiran tiran added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Jul 28, 2013
    @pitrou
    Copy link
    Member

    pitrou commented Jul 28, 2013

    Please use the "y*" format, not "y#".
    Also, I would lower-case "pbkdf2", just as we already lower-case "md5", "sha1", etc.

    @tiran
    Copy link
    Member Author

    tiran commented Oct 12, 2013

    Done

    @pitrou
    Copy link
    Member

    pitrou commented Oct 12, 2013

    The patch looks good at first sight. It still needs docs and tests :)

    Just one thing: are we sure PKCS5_PBKDF2_HMAC is defined on old OpenSSL versions, or does it need a #ifdef?

    @tiran
    Copy link
    Member Author

    tiran commented Oct 12, 2013

    Here is a new patch with tests, documentation and some minor improvements. The last argument is now called dklen. If dklen is omitted or None than dklen is set to digest size of the hash algorithm.

    @tiran
    Copy link
    Member Author

    tiran commented Oct 12, 2013

    Fixed copy n' paste bug in docs.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 12, 2013

    New changeset 5fd56d6d3fce by Christian Heimes in branch 'default':
    Issue bpo-18582: Add 'pbkdf2_hmac' to the hashlib module.
    http://hg.python.org/cpython/rev/5fd56d6d3fce

    @tiran
    Copy link
    Member Author

    tiran commented Oct 12, 2013

    Thanks Antoine!

    @tiran tiran closed this as completed Oct 12, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 19, 2013

    New changeset 0a26ef834a49 by Christian Heimes in branch 'default':
    Issue bpo-18582: provide a faster C implementation of pbkdf2_hmac that works with OpenSSL < 1.0
    http://hg.python.org/cpython/rev/0a26ef834a49

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 19, 2013

    New changeset 88fac1574049 by Christian Heimes in branch 'default':
    Issue bpo-18582: HMAC_CTX_copy() is not available on OpenSSL < 1.0
    http://hg.python.org/cpython/rev/88fac1574049

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 19, 2013

    New changeset a15fcb847515 by Christian Heimes in branch 'default':
    Issue bpo-18582: skip test of _hashlib.pbkdf2_hmac if OpenSSL is not available or too old
    http://hg.python.org/cpython/rev/a15fcb847515

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 6, 2013

    New changeset 07fa1ed0d551 by Christian Heimes in branch 'default':
    Issue bpo-18582: fix memory leak in pbkdf2 code
    http://hg.python.org/cpython/rev/07fa1ed0d551

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tiran @pitrou