New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_elementtree.c calls Python callbacks while a Python exception is set #62701
Comments
The ElementTree module allows to write a XML parser using Python callbacks. The module relies on the expat library which is implemented in C. Expat calls these Python callbacks, but ElementTree does not check if a Python exception was raised or not. Example 1: import unittest
from xml.etree import ElementTree as ET
class Target(object):
def start(self, tag, attrib):
print("start")
raise ValueError("raise start")
def end(self, tag):
print("end")
raise ValueError("raise end")
def close(self):
print("close")
raise ValueError("raise close")
parser = ET.XMLParser(target=Target())
parser.feed("<root><test /></root>") Output with Python 3.3: start
startendendTraceback (most recent call last):
File "x.py", line 18, in <module>
parser.feed("<root><test /></root>")
File "x.py", line 10, in end
print("end")
File "x.py", line 10, in end
print("end")
File "x.py", line 6, in start
print("start")
File "x.py", line 7, in start
raise ValueError("raise start")
ValueError: raise start start() was called twice, as end() method, even if the first start() method raised an exception. The traceback is strange: it looks like end() was called by start(), which is wrong. Example 2: import unittest
from xml.etree import ElementTree as ET
class Target(object):
def start(self, tag, attrib):
raise ValueError("raise start")
def end(self, tag):
raise ValueError("raise end")
def close(self):
raise ValueError("raise close")
parser = ET.XMLParser(target=Target())
parser.feed("<root><test /></root>") Output with Python 3.3: Traceback (most recent call last):
File "x.py", line 15, in <module>
parser.feed("<root><test /></root>")
File "x.py", line 9, in end
raise ValueError("raise end")
ValueError: raise end end() was called even if start() already failed. The exception which was set by start has been replaced by end() exception. In my opinion, it's not a good thing to call PyEval_EvalFrameEx() and similar functions when a Python exception is set, because it behaves badly (ex: print("end") in Example 1 raises an exception... which is wrong, the traceback is also corrupted) and may replaces the old exception with a new exception (ex: "end" replaces "started"). |
For the issue bpo-18408, I added assertions in PyEval_EvalFrameEx() and similar functions to exit with an assertion error in debug mode if these functions are called with an exception set: New changeset 48a869a39e2d by Victor Stinner in branch 'default': New changeset 5bd9db528aed by Victor Stinner in branch 'default': lxml test suite failed with an C assertion error because of these changes. I fixed the issue with the following change: New changeset 6ec0e9347dd4 by Victor Stinner in branch 'default': Instead of having to check if an exception is set in each Python callback, it would be better to "stop" the XML parser. Modules/pyexpat.c calls "flag_error(self); XML_SetCharacterDataHandler(self->itself, noop_character_data_handler);" on error: /* This handler is used when an error has been detected, in the hope
that actual parsing can be terminated early. This will only help
if an external entity reference is encountered. */
static int
error_external_entity_ref_handler(XML_Parser parser,
const XML_Char *context,
const XML_Char *base,
const XML_Char *systemId,
const XML_Char *publicId)
{
return 0;
}
/* Dummy character data handler used when an error (exception) has
been detected, and the actual parsing can be terminated early.
This is needed since character data handler can't be safely removed
from within the character data handler, but can be replaced. It is
used only from the character data handler trampoline, and must be
used right after `flag_error()` is called. */
static void
noop_character_data_handler(void *userData, const XML_Char *data, int len)
{
/* Do nothing. */
}
static void
flag_error(xmlparseobject *self)
{
clear_handlers(self, 0);
XML_SetExternalEntityRefHandler(self->itself,
error_external_entity_ref_handler);
} |
New changeset 5a6cdc0d7de1 by Victor Stinner in branch 'default': |
See also the issue bpo-18488, similar issue in sqlite. |
I created the issue bpo-18733 to track this optimization. The initial issue is fixed, so I'm closing it. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: