Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: forward apply patch for handling SystemExit #62396

Closed
serwy mannequin opened this issue Jun 12, 2013 · 3 comments
Closed

IDLE: forward apply patch for handling SystemExit #62396

serwy mannequin opened this issue Jun 12, 2013 · 3 comments
Assignees
@serwy
Labels
topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@serwy
Copy link
Mannequin

serwy mannequin commented Jun 12, 2013

BPO 18196
Nosy @rhettinger, @terryjreedy, @serwy
Files
  • catch_exit.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serwy'
closed_at = <Date 2013-06-12.03:25:54.971>
created_at = <Date 2013-06-12.03:20:33.732>
labels = ['expert-IDLE', 'type-bug']
title = 'IDLE: forward apply patch for handling SystemExit'
updated_at = <Date 2013-06-12.03:25:54.970>
user = 'https://github.com/serwy'

    bugs.python.org fields:

    activity = <Date 2013-06-12.03:25:54.970>
actor = 'roger.serwy'
assignee = 'roger.serwy'
closed = True
closed_date = <Date 2013-06-12.03:25:54.971>
closer = 'roger.serwy'
components = ['IDLE']
creation = <Date 2013-06-12.03:20:33.732>
creator = 'roger.serwy'
dependencies = []
files = ['30551']
hgrepos = []
issue_num = 18196
keywords = ['patch']
message_count = 3.0
messages = ['191007', '191008', '191009']
nosy_count = 4.0
nosy_names = ['rhettinger', 'terry.reedy', 'roger.serwy', 'python-dev']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18196'
versions = ['Python 3.3', 'Python 3.4']
    @serwy
    Copy link
    Mannequin Author

    serwy mannequin commented Jun 12, 2013

    As a formality, I opened this issue to apply 872a3aca2120 to the 3.x branch. This addresses a concern brought up by Terry in msg187323 from bpo-5492. Here's the relevant part of the message:

    """
    Without or with patch, quit() or exit brings up TK box
    (?) The program is still running!
    Do you want to kill it?
    [OK] [Cancel]
    Did this always happen?

    [Cancel] causes traceback (not good, regression?)
Traceback (most recent call last):
  File "<pyshell#0>", line 1, in <module>
    quit()
  File "D:\Python\dev\cpython\lib\site.py", line 356, in __call__
    raise SystemExit(code)
SystemExit: None
"""

    @serwy serwy mannequin self-assigned this Jun 12, 2013
    @serwy serwy mannequin added topic-IDLE type-bug An unexpected behavior, bug, or error labels Jun 12, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 12, 2013

    New changeset 0e56d4e37777 by Roger Serwy in branch '3.3':
    bpo-18196: Avoid displaying spurious SystemExit tracebacks.
    http://hg.python.org/cpython/rev/0e56d4e37777

    New changeset 479aad3bb122 by Roger Serwy in branch 'default':
    bpo-18196: merge with 3.3
    http://hg.python.org/cpython/rev/479aad3bb122

    @serwy
    Copy link
    Mannequin Author

    serwy mannequin commented Jun 12, 2013

    And it's applied.

    @serwy serwy mannequin closed this as completed Jun 12, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serwy serwy

    Labels
    topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    0 participants