Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imp.reload() to importlib #62393

Closed
brettcannon opened this issue Jun 11, 2013 · 7 comments
Closed

Move imp.reload() to importlib #62393

brettcannon opened this issue Jun 11, 2013 · 7 comments
Assignees
@brettcannon
Labels
stdlib Python modules in the Lib dir

Comments

@brettcannon
Copy link
Member

BPO 18193
Nosy @brettcannon, @berkerpeksag
Files
  • issue18193.diff
  • issue18193_v2.diff
  • issue18193_v3.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
closed_at = <Date 2013-06-14.19:06:02.229>
created_at = <Date 2013-06-11.20:45:11.039>
labels = ['library']
title = 'Move imp.reload() to importlib'
updated_at = <Date 2013-06-14.19:06:02.228>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2013-06-14.19:06:02.228>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2013-06-14.19:06:02.229>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2013-06-11.20:45:11.039>
creator = 'brett.cannon'
dependencies = []
files = ['30573', '30585', '30586']
hgrepos = []
issue_num = 18193
keywords = ['patch']
message_count = 7.0
messages = ['190982', '191070', '191140', '191141', '191142', '191144', '191145']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'Arfrever', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue18193'
versions = ['Python 3.4']
    @brettcannon
    Copy link
    Member Author

    For convenience it should live directly off of importlib and not importlib.util.

    @brettcannon brettcannon added the stdlib Python modules in the Lib dir label Jun 11, 2013
    @berkerpeksag
    Copy link
    Member

    Here's a patch. Changes:

    • Used types.ModuleType instead of type(sys)
    • Updated imp and importlib docs
    • Moved test_imp.ReloadTests to test_importlib.test_api.ReloadTests

    @berkerpeksag
    Copy link
    Member

    Updated patch adressing Brett's comments.

    @brettcannon
    Copy link
    Member Author

    Answered Berker's questions from the review. At this point Berker just needs to tweak one line in the test and it should then be good to go.

    @brettcannon
    Copy link
    Member Author

    With Berker's nice use of TestCase.subTest() I think the patch is good to go! I should hopefully get this checked in today or tomorrow.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 14, 2013

    New changeset 01da7bf11ca1 by Brett Cannon in branch 'default':
    Issue bpo-18193: Add importlib.reload(), documenting (but not
    http://hg.python.org/cpython/rev/01da7bf11ca1

    @brettcannon
    Copy link
    Member Author

    Thanks for the patch, Berker!

    @brettcannon brettcannon self-assigned this Jun 14, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @brettcannon brettcannon

    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @brettcannon