Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imp.get_magic() to importlib #62392

Closed
brettcannon opened this issue Jun 11, 2013 · 10 comments
Closed

Move imp.get_magic() to importlib #62392

brettcannon opened this issue Jun 11, 2013 · 10 comments
Assignees
@brettcannon
Labels
stdlib Python modules in the Lib dir

Comments

@brettcannon
Copy link
Member

BPO 18192
Nosy @warsaw, @brettcannon

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2013-06-14.23:03:12.452>
created_at = <Date 2013-06-11.20:44:04.897>
labels = ['library']
title = 'Move imp.get_magic() to importlib'
updated_at = <Date 2013-06-14.23:03:12.452>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-06-14.23:03:12.452>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2013-06-14.23:03:12.452>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2013-06-11.20:44:04.897>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 18192
keywords = []
message_count = 10.0
messages = ['190981', '190985', '190987', '190988', '191039', '191146', '191148', '191149', '191150', '191167']
nosy_count = 4.0
nosy_names = ['barry', 'brett.cannon', 'Arfrever', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue18192'
versions = ['Python 3.4']
@brettcannon
Copy link
Member Author

As part of deprecating imp, need to move imp.get_magic() to importlib where it now belongs. Will be exposed as an attribute instead of a function, though.

@brettcannon brettcannon added the stdlib Python modules in the Lib dir label Jun 11, 2013
@brettcannon
Copy link
Member Author

This could be an attribute on importlib.machinery.SourceLoader instead of an attribute in importlib.util.

@warsaw
Copy link
Member

warsaw commented Jun 11, 2013

On Jun 11, 2013, at 08:44 PM, Brett Cannon wrote:

As part of deprecating imp, need to move imp.get_magic() to importlib where
it now belongs. Will be exposed as an attribute instead of a function,
though.

so, importlib.magic ?

@warsaw
Copy link
Member

warsaw commented Jun 11, 2013

I'd like to see it be more easily accessible.

@brettcannon
Copy link
Member Author

So what are your arguments to making it more accessible? The typical user won't need to use it so I don't know if it really requires being off of importlib directly like find_loader, import_module, or (eventually) reload (which for convenience-sake while at the interpreter should be there).

While I'm happy to entertain the argument that it should be importlib.machinery.MAGIC (like the file suffixes for the various file types) instead of importlib.abc.SourceLoader.magic, I don't want to make it importlib.magic.

@brettcannon
Copy link
Member Author

Any chance I could get a response to my questions, Barry, soon? I think I can finish the rest of the issues related to deprecating imp this weekend if we can settle this quickly.

@warsaw
Copy link
Member

warsaw commented Jun 14, 2013

The only argument I have about it is that if someone *does* want to use, it should be fairly easily discoverable. Also, since it's a concrete value, it seems a little weird that it's stashed in an abc.

I suppose importlib.machinery.MAGIC is better than importlib.abc.SourceLoader.magic

@brettcannon
Copy link
Member Author

I'll put it into importlib.util.MAGIC.

@warsaw
Copy link
Member

warsaw commented Jun 14, 2013

On Jun 14, 2013, at 07:53 PM, Brett Cannon wrote:

I'll put it into importlib.util.MAGIC.

+1

@brettcannon brettcannon assigned brettcannon and unassigned warsaw Jun 14, 2013
@python-dev
Copy link
Mannequin

python-dev mannequin commented Jun 14, 2013

New changeset 5619bc2d8207 by Brett Cannon in branch 'default':
Issue bpo-18192: Introduce importlib.util.MAGIC_NUMBER and document the
http://hg.python.org/cpython/rev/5619bc2d8207

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @warsaw