Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define is_package for NamespaceLoader #62258

Closed
brettcannon opened this issue May 25, 2013 · 5 comments
Closed

Define is_package for NamespaceLoader #62258

brettcannon opened this issue May 25, 2013 · 5 comments
Assignees
@brettcannon
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

BPO 18058
Nosy @warsaw, @brettcannon, @theller, @ericvsmith

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2013-06-16.18:57:57.466>
created_at = <Date 2013-05-25.15:48:43.158>
labels = ['type-bug', 'library']
title = 'Define is_package for NamespaceLoader'
updated_at = <Date 2013-06-18.19:49:54.055>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-06-18.19:49:54.055>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2013-06-16.18:57:57.466>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2013-05-25.15:48:43.158>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 18058
keywords = []
message_count = 5.0
messages = ['189972', '190108', '191280', '191428', '191429']
nosy_count = 5.0
nosy_names = ['barry', 'brett.cannon', 'theller', 'eric.smith', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18058'
versions = ['Python 3.4']
@brettcannon
Copy link
Member Author

Is there a reason that is_package() is not defined for NamespaceLoader? If it's just an oversight then adding it would let -m would work with namespace packages. The other abstract methods on InspectLoader can also be implemented or raise ImportError as appropriate.

Just assign to me if you are okay with seeing this happen.

@brettcannon brettcannon added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 25, 2013
@ericvsmith
Copy link
Member

I think it's just an oversight.

@ericvsmith ericvsmith assigned brettcannon and unassigned warsaw May 26, 2013
@python-dev
Copy link
Mannequin

python-dev mannequin commented Jun 16, 2013

New changeset ebec625b13f9 by Brett Cannon in branch 'default':
Issues bpo-18058, 18057: Make importlib._bootstrap.NamespaceLoader
http://hg.python.org/cpython/rev/ebec625b13f9

@theller
Copy link

theller commented Jun 18, 2013

Brett, can these changes be merged into 3.3 also?

@brettcannon
Copy link
Member Author

No because it would mean new functionality in a bugfix release.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @warsaw @ericvsmith @theller