Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to descriptor howto #62094

Closed
nedbat opened this issue May 3, 2013 · 13 comments
Closed

Edits to descriptor howto #62094

nedbat opened this issue May 3, 2013 · 13 comments
Assignees
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir

Comments

@nedbat
Copy link
Member

nedbat commented May 3, 2013

BPO 17894
Nosy @rhettinger, @pitrou, @nedbat, @ezio-melotti, @Julian, @ammaraskar
Files
  • descriptor_howto.patch
  • issue17894.diff
  • descriptor_howto_2.patch: The new patch, incorporating the other two.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/rhettinger'
    closed_at = <Date 2019-10-11.01:30:05.983>
    created_at = <Date 2013-05-03.02:11:51.837>
    labels = ['3.7', 'docs']
    title = 'Edits to descriptor howto'
    updated_at = <Date 2019-10-11.01:30:05.981>
    user = 'https://github.com/nedbat'

    bugs.python.org fields:

    activity = <Date 2019-10-11.01:30:05.981>
    actor = 'rhettinger'
    assignee = 'rhettinger'
    closed = True
    closed_date = <Date 2019-10-11.01:30:05.983>
    closer = 'rhettinger'
    components = ['Documentation']
    creation = <Date 2013-05-03.02:11:51.837>
    creator = 'nedbat'
    dependencies = []
    files = ['30111', '30125', '30127']
    hgrepos = []
    issue_num = 17894
    keywords = ['patch']
    message_count = 13.0
    messages = ['188289', '188384', '188418', '188421', '188423', '188429', '288666', '288690', '320796', '354304', '354311', '354366', '354416']
    nosy_count = 8.0
    nosy_names = ['rhettinger', 'pitrou', 'nedbat', 'ezio.melotti', 'docs@python', 'Julian', 'tshepang', 'ammar2']
    pr_nums = []
    priority = 'low'
    resolution = 'rejected'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue17894'
    versions = ['Python 3.7']

    @nedbat
    Copy link
    Member Author

    nedbat commented May 3, 2013

    I find the explanations in the Descriptor howto to be difficult to understand. I took a stab at changing the first few sections to introduce the concepts in an easier-to-grasp style.

    bpo-12077 also covers a little bit of this.

    @nedbat nedbat added the docs Documentation in the Doc dir label May 3, 2013
    @rhettinger rhettinger assigned rhettinger and unassigned docspython May 3, 2013
    @ezio-melotti
    Copy link
    Member

    Attached a patch that rephrases part of the suggestions made by Ned.

    @nedbat
    Copy link
    Member Author

    nedbat commented May 4, 2013

    I worked with Ezio to make a new patch with the full edits.

    I have other ideas for edits to the rest of the document, but we can discuss those if you like these...

    @rhettinger
    Copy link
    Contributor

    Please don't go crazy with this. I will look at the suggestions and make some edits to improve its readability but am not going to change it into a breezy conversational style. Instead, I'll likely put together a separate descriptor tutorial that presents an easier on-ramp (in contrast to an authoritative document closely tied to the actually implementation details).

    @nedbat
    Copy link
    Member Author

    nedbat commented May 5, 2013

    Raymond, I'm glad you're on top of this. I would have thought the howto should be the easy on-ramp, and deeper authoritative details should go in the reference section.

    @pitrou
    Copy link
    Member

    pitrou commented May 5, 2013

    in contrast to an authoritative document closely tied to the actually
    implementation details

    I fail to understand why a HOWTO should be an authoritative document closely tied to implementation details. If you don't want this document to be beginner-friendly, please move it into the language reference, not the HOWTO directory.

    @nedbat
    Copy link
    Member Author

    nedbat commented Feb 27, 2017

    I'm still interested in moving this forward. I can make a GitHub pull request if that would help.

    @rhettinger
    Copy link
    Contributor

    I will work on it thank you.

    @rhettinger rhettinger added the 3.7 (EOL) end of life label Feb 28, 2017
    @Julian
    Copy link
    Mannequin

    Julian mannequin commented Jun 30, 2018

    This seems very very slightly overly conversational (specifically the "That's all there is to it" sentence), but overall like a pretty decent improvement here.

    Personally I'd axe that sentence but then seems like this should be merged as-is and any further improvements could always pile on after given how long this has sat.

    @ammaraskar
    Copy link
    Member

    Any updates on this? Some of the re-organization and simplifications here look pretty good overall and make the guide way more approachable.

    Seeing as how this has been sitting a while and Github has an option allow maintainers to make edits to PRs. Raymond, would you be fine with Ned making a PR out of these changes to solicit your feedback and incorporate it the way you want?

    @rhettinger
    Copy link
    Contributor

    I've been working on some updates to the descriptor how-to and will likely post next month or so (there have been other priorities for 3.8 and I had had some limitations regarding posting my training material). I'm going in a different direction than the patches proposed here and am going to mark this tracker issue as closed.

    FWIW, this entry is unique in that it is a work of individual authorship, originally posted on my own website. When the analysis became a popular, I was asked to post it on python.org. I will continue to maintain and improve it but am not open to a substantial stylistic rewrite changing it into someone else's style (people can use their own blog posts for that purpose).

    @nedbat
    Copy link
    Member Author

    nedbat commented Oct 10, 2019

    I think it's a bad precedent to have pages in the official docs that belong to a single author. If you want to maintain that kind of control, it should go on your blog. Part of the agreement for having material added to the official docs should be the understanding that they are fair game for community contributions.

    @nedbat nedbat reopened this Oct 10, 2019
    @rhettinger
    Copy link
    Contributor

    I am actively working on updates. However, the work on Python 3.8's whatsnew and doc fixes are a more immediate priority. Cumulatively, I've put an a lot of effort in to this and have made a continuous stream of improvements over the years including this year. In a way, maintaining this entry is not much different from being a module maintainer who has the principal responsibility and authority over the updates. This is something that I frequently teach and have battle tested course material that I'm looking forward to including in the entry.

    Please give me space and don't shove. IMO some of the past posts on this subject are border-line abusive, leaving me feeling hounded and degraded (especially with respect to my writing style). Please be kind and let me continue to improve my contribution at my own pace.

    Please don't re-open this issue. I have marked the patch as rejected because it is at odds with the improvements that I already have in progress and because some of it is essentially just a stylistic difference.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants