Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support http.server passing bind address via commend line argument #61964

Closed
malteswart mannequin opened this issue Apr 16, 2013 · 6 comments
Closed

Support http.server passing bind address via commend line argument #61964

malteswart mannequin opened this issue Apr 16, 2013 · 6 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@malteswart
Copy link
Mannequin

malteswart mannequin commented Apr 16, 2013

BPO 17764
Nosy @orsenthil, @bitdancer, @berkerpeksag
Files
  • http-server-bind-arg.patch: Add --bind, -b option to http.server module
  • http-server-bind-arg2.patch: Updated patch + Documentation update
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-09-15.16:39:35.909>
created_at = <Date 2013-04-16.16:28:50.517>
labels = ['type-feature', 'library']
title = 'Support http.server passing bind address via commend line argument'
updated_at = <Date 2013-09-15.16:39:35.907>
user = 'https://bugs.python.org/malteswart'

    bugs.python.org fields:

    activity = <Date 2013-09-15.16:39:35.907>
actor = 'orsenthil'
assignee = 'none'
closed = True
closed_date = <Date 2013-09-15.16:39:35.909>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2013-04-16.16:28:50.517>
creator = 'malte.swart'
dependencies = []
files = ['29886', '29969']
hgrepos = []
issue_num = 17764
keywords = ['patch']
message_count = 6.0
messages = ['187102', '187368', '187517', '187521', '197783', '197784']
nosy_count = 5.0
nosy_names = ['orsenthil', 'r.david.murray', 'python-dev', 'berker.peksag', 'malte.swart']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17764'
versions = ['Python 3.4']
    @malteswart
    Copy link
    Mannequin Author

    malteswart mannequin commented Apr 16, 2013

    The http.server supports a shortcut to start it directly via the interpreter. To be able to use this shortcut on server with insecure interfaces, this patch adds a --bind, -b option to specify a bind address.

    @malteswart malteswart mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 16, 2013
    @berkerpeksag
    Copy link
    Member

    I left comments on Rietveld. The patch also needs a documentation update.

    @malteswart
    Copy link
    Mannequin Author

    malteswart mannequin commented Apr 21, 2013

    I have updated the patch and added a paragraph for this option to the documentation.

    Shall I add this issue to the changelog list for python 3.4.0 alpha 1?

    @bitdancer
    Copy link
    Member

    Thanks for proposing this and working on it Malte. Could you please submit a contributor agreement? (http://www.python.org/psf/contrib).

    We will add the Misc/NEWS entry when we commit the patch; that file changes so rapidly that any patch to it quickly becomes outdated. You could add an entry to Doc/whatsnew/3.4, though, if you were so moved. If not we'll add that too when we commit.

    For the doc patch, I think the first sentence would be clearer if it said "By default the server binds to all available interfaces." I'll probably tweak a couple other words for better English phrasing when I commit it, as well.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 15, 2013

    New changeset a248655c8261 by Senthil Kumaran in branch 'default':
    Expose --bind argument for http.server, enable http.server to bind to a user
    http://hg.python.org/cpython/rev/a248655c8261

    @orsenthil
    Copy link
    Member

    Found the patch suitable and had addressed Berker Pesag's review comments too. Thanks for contributing, Malte Swart and thanks for submitting the contributor agreement too.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @berkerpeksag @orsenthil @bitdancer