Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _PyUnicodeWriter API for CJK decoders #61893

Closed
vstinner opened this issue Apr 10, 2013 · 4 comments
Closed

Use _PyUnicodeWriter API for CJK decoders #61893

vstinner opened this issue Apr 10, 2013 · 4 comments
Labels
topic-unicode

Comments

@vstinner
Copy link
Member

BPO 17693
Nosy @vstinner, @ezio-melotti, @serhiy-storchaka
Files
  • cjkcodecs_writer.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-04-11.20:13:16.483>
created_at = <Date 2013-04-10.23:50:55.899>
labels = ['expert-unicode']
title = 'Use _PyUnicodeWriter API for CJK decoders'
updated_at = <Date 2013-04-14.17:31:40.389>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2013-04-14.17:31:40.389>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2013-04-11.20:13:16.483>
closer = 'python-dev'
components = ['Unicode']
creation = <Date 2013-04-10.23:50:55.899>
creator = 'vstinner'
dependencies = []
files = ['29769']
hgrepos = []
issue_num = 17693
keywords = ['patch']
message_count = 4.0
messages = ['186536', '186587', '186868', '186932']
nosy_count = 4.0
nosy_names = ['vstinner', 'ezio.melotti', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue17693'
versions = ['Python 3.4']
    @vstinner
    Copy link
    Member Author

    Attached patch modify CJK decoders to use the _PyUnicodeWriter API. It adds a new _PyUnicodeWriter_WriteChar() function.

    Performances are not optimal: the overallocation is not well controlled. I will try to adjust it later (if this patch is accepted).

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 11, 2013

    New changeset bcecf3910162 by Victor Stinner in branch 'default':
    Close bpo-17693: Rewrite CJK decoders to use the _PyUnicodeWriter API instead of
    http://hg.python.org/cpython/rev/bcecf3910162

    @python-dev python-dev mannequin closed this as completed Apr 11, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 14, 2013

    New changeset d621bdaed7c3 by Victor Stinner in branch 'default':
    Issue bpo-17693: CJK encoders now use the new Unicode API (PEP-393)
    http://hg.python.org/cpython/rev/d621bdaed7c3

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 14, 2013

    New changeset ffd4b72f7f95 by Victor Stinner in branch 'default':
    Issue bpo-17693: Fix memory/reference leaks
    http://hg.python.org/cpython/rev/ffd4b72f7f95

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    topic-unicode
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner