Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test discovery for test_time.py #61890

Closed
zware opened this issue Apr 10, 2013 · 3 comments
Closed

Fix test discovery for test_time.py #61890

zware opened this issue Apr 10, 2013 · 3 comments
Assignees
@ezio-melotti
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@zware
Copy link
Member

zware commented Apr 10, 2013

BPO 17690
Nosy @brettcannon, @ezio-melotti, @zware
Files
  • test_time_discovery.diff: test_time.py fix, version 1
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
closed_at = <Date 2013-04-11.17:31:33.834>
created_at = <Date 2013-04-10.18:58:06.987>
labels = ['type-bug', 'tests']
title = 'Fix test discovery for test_time.py'
updated_at = <Date 2013-04-11.17:31:33.833>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2013-04-11.17:31:33.833>
actor = 'ezio.melotti'
assignee = 'ezio.melotti'
closed = True
closed_date = <Date 2013-04-11.17:31:33.834>
closer = 'ezio.melotti'
components = ['Tests']
creation = <Date 2013-04-10.18:58:06.987>
creator = 'zach.ware'
dependencies = []
files = ['29766']
hgrepos = []
issue_num = 17690
keywords = ['patch']
message_count = 3.0
messages = ['186526', '186568', '186569']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'ezio.melotti', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17690'
versions = ['Python 3.3', 'Python 3.4']
    @zware
    Copy link
    Member Author

    zware commented Apr 10, 2013

    Just inheritance issues in this one. The patch removes _BaseYearTest as its only use was as a unittest.TestCase subclass to inherit from, which caused the discovery issues.

    @zware zware added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Apr 10, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 11, 2013

    New changeset 20efcabcd5c0 by Ezio Melotti in branch '3.3':
    bpo-17690: test_time now works with unittest test discovery. Patch by Zachary Ware.
    http://hg.python.org/cpython/rev/20efcabcd5c0

    New changeset 6cc56e21a74d by Ezio Melotti in branch 'default':
    bpo-17690: merge with 3.3.
    http://hg.python.org/cpython/rev/6cc56e21a74d

    @ezio-melotti
    Copy link
    Member

    Fixed, thanks for the patch!

    @ezio-melotti ezio-melotti self-assigned this Apr 11, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ezio-melotti ezio-melotti

    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zware @ezio-melotti