Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC_LIBOBJ replacement of fileblocks #61803

Closed
rpetrov mannequin opened this issue Mar 31, 2013 · 4 comments
Closed

AC_LIBOBJ replacement of fileblocks #61803

rpetrov mannequin opened this issue Mar 31, 2013 · 4 comments
Labels
build The build process and cross-build

Comments

@rpetrov
Copy link
Mannequin

rpetrov mannequin commented Mar 31, 2013

BPO 17603
Nosy @vadmium
Files
  • 0014-MINGW-AC_LIBOBJ-replacement-of-fileblocks.patch
  • avoid-fileblocks.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-03-17.06:23:07.738>
created_at = <Date 2013-03-31.20:13:39.386>
labels = ['build']
title = 'AC_LIBOBJ replacement of fileblocks'
updated_at = <Date 2016-03-17.06:23:07.723>
user = 'https://bugs.python.org/rpetrov'

    bugs.python.org fields:

    activity = <Date 2016-03-17.06:23:07.723>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-03-17.06:23:07.738>
closer = 'martin.panter'
components = ['Build']
creation = <Date 2013-03-31.20:13:39.386>
creator = 'rpetrov'
dependencies = []
files = ['29636', '42123']
hgrepos = []
issue_num = 17603
keywords = ['patch']
message_count = 4.0
messages = ['185665', '261534', '261883', '261887']
nosy_count = 3.0
nosy_names = ['rpetrov', 'python-dev', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue17603'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']
    @rpetrov
    Copy link
    Mannequin Author

    rpetrov mannequin commented Mar 31, 2013

    split of bpo-3871 - actually this is not mingw* specific - it is for all platforms without fileblocks

    @rpetrov rpetrov mannequin added type-feature A feature request or enhancement build The build process and cross-build labels Mar 31, 2013
    @vadmium
    Copy link
    Member

    vadmium commented Mar 10, 2016

    IMO this is a fault of the autowhatever configuration stuff, not just an enhancement. If configure.ac determines that there is no st_blocks field, it tries to link against a non-existant fileblocks.o file:

    ./mingw/Makefile:220:LIBOBJS= ${LIBOBJDIR}fileblocks$U.o
    i486-mingw32-gcc: error: Python/fileblocks.o: No such file or directory

    I am not really an autoconf or whatever expert, but it seems if you use a lower-level bit of configure.ac code it avoids the problem; see avoid-fileblocks.patch.

    @vadmium vadmium added build The build process and cross-build and removed build The build process and cross-build type-feature A feature request or enhancement labels Mar 10, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 17, 2016

    New changeset acbeb33dc76a by Martin Panter in branch '2.7':
    Issue bpo-17603: Check for st_blocks field without requiring fileblocks.o
    https://hg.python.org/cpython/rev/acbeb33dc76a

    New changeset 0774398c3433 by Martin Panter in branch '3.5':
    Issue bpo-17603: Check for st_blocks field without requiring fileblocks.o
    https://hg.python.org/cpython/rev/0774398c3433

    New changeset 628bd1ebfa22 by Martin Panter in branch 'default':
    Issue bpo-17603: Merge configure.ac fix from 3.5
    https://hg.python.org/cpython/rev/628bd1ebfa22

    @vadmium
    Copy link
    Member

    vadmium commented Mar 17, 2016

    I assume that should have fixed the problem, but I have only tested it in roundabout ways, so it would be good to get confirmation if it helps e.g. the original Ming GW problem.

    @vadmium vadmium closed this as completed Mar 17, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vadmium