Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mingw: detect REPARSE_DATA_BUFFER #61799

Closed
rpetrov mannequin opened this issue Mar 31, 2013 · 9 comments
Closed

mingw: detect REPARSE_DATA_BUFFER #61799

rpetrov mannequin opened this issue Mar 31, 2013 · 9 comments
Labels
build The build process and cross-build OS-windows type-feature A feature request or enhancement

Comments

@rpetrov
Copy link
Mannequin

rpetrov mannequin commented Mar 31, 2013

BPO 17599
Nosy @pfmoore, @tjguk, @vadmium, @zware, @eryksun, @zooba
Files
  • 0010-MINGW-detect-REPARSE_DATA_BUFFER.patch
  • 0009-MINGW-detect-REPARSE_DATA_BUFFER.patch: status on 2014-08-02
  • Py_REPARSE.patch
  • Py_REPARSE.v2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-08-04.08:33:14.623>
created_at = <Date 2013-03-31.19:59:37.545>
labels = ['type-feature', 'OS-windows', 'build']
title = 'mingw: detect REPARSE_DATA_BUFFER'
updated_at = <Date 2016-08-04.08:33:14.622>
user = 'https://bugs.python.org/rpetrov'

    bugs.python.org fields:

    activity = <Date 2016-08-04.08:33:14.622>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-08-04.08:33:14.623>
closer = 'martin.panter'
components = ['Build', 'Windows']
creation = <Date 2013-03-31.19:59:37.545>
creator = 'rpetrov'
dependencies = []
files = ['29632', '36222', '43907', '43931']
hgrepos = []
issue_num = 17599
keywords = ['patch']
message_count = 9.0
messages = ['185660', '266050', '271432', '271449', '271602', '271605', '271632', '271941', '271957']
nosy_count = 8.0
nosy_names = ['paul.moore', 'tim.golden', 'rpetrov', 'python-dev', 'martin.panter', 'zach.ware', 'eryksun', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17599'
versions = ['Python 3.6']
    @rpetrov
    Copy link
    Mannequin Author

    rpetrov mannequin commented Mar 31, 2013

    split of bpo-3871.

    @rpetrov rpetrov mannequin added build The build process and cross-build type-feature A feature request or enhancement labels Mar 31, 2013
    @vadmium
    Copy link
    Member

    vadmium commented May 22, 2016

    Would it be better to define all the things in "winreparse.h" with names that are less likely to conflict, say Py_REPARSE_DATA_BUFFER etc? This would be a more general way to avoid conflicts, and also avoid hacking the configure script.

    Also, is the “#ifndef MAXIMUM_REPARSE_DATA_BUFFER_SIZE” condition necessary?

    @vadmium vadmium added OS-windows and removed build The build process and cross-build labels May 22, 2016
    @vadmium
    Copy link
    Member

    vadmium commented Jul 27, 2016

    Here is a patch implementing my suggestion to unconditionally define everything, prefixed with Py_ instead. Not tested on a normal Windows build.

    @zooba
    Copy link
    Member

    zooba commented Jul 27, 2016

    Worth checking if the headers in VC14 have the structure now, as it may simplify the whole thing.

    If not, I'd add a leading underscore to the name so nobody confuses it for public API in the future.

    @vadmium
    Copy link
    Member

    vadmium commented Jul 29, 2016

    Leading underscore is a good idea.

    I have no idea if VC14 includes the structure, but I suspect if it was added with this name, we would know because it would cause the same conflict that Min GW caused.

    @eryksun
    Copy link
    Contributor

    eryksun commented Jul 29, 2016

    REPARSE_DATA_BUFFER is defined in the WDK filesystem header, km\ntifs.h. It's not defined in the user-mode SDK.

    @zooba
    Copy link
    Member

    zooba commented Jul 29, 2016

    I think the WDK is still separate from the Windows SDK, so probably best to keep the custom definition with a comment specifying which file it came from (so whoever diagnoses an obscure issue in the future can find it quickly).

    With the comment, I'm fine with the patch. If you haven't built on MSVC then keep an eye on the build bots until it goes through in case something unpredictable happens.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 4, 2016

    New changeset e4ddfa61199c by Martin Panter in branch 'default':
    Issue bpo-17599: Use unique _Py_REPARSE_DATA_BUFFER etc names to avoid conflict
    https://hg.python.org/cpython/rev/e4ddfa61199c

    @vadmium
    Copy link
    Member

    vadmium commented Aug 4, 2016

    Thanks for your feedback. I add a reference to km\ntifs.h in the comment. The buildbots seem generally happy with the change. (One timed out in the tests, but that seems to be an existing intermittent problem.)

    @vadmium vadmium closed this as completed Aug 4, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @eryksun @vadmium @zooba