Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftplib raises exception if ssl module is not available #61654

Closed
rkackley mannequin opened this issue Mar 18, 2013 · 3 comments
Closed

ftplib raises exception if ssl module is not available #61654

rkackley mannequin opened this issue Mar 18, 2013 · 3 comments
Assignees
@giampaolo
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@rkackley
Copy link
Mannequin

rkackley mannequin commented Mar 18, 2013

BPO 17452
Nosy @giampaolo
Files
  • ftplib.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/giampaolo'
closed_at = <Date 2013-03-18.09:22:06.755>
created_at = <Date 2013-03-18.06:19:27.972>
labels = ['type-bug', 'library']
title = 'ftplib raises exception if ssl module is not available'
updated_at = <Date 2013-03-18.09:22:06.754>
user = 'https://bugs.python.org/rkackley'

    bugs.python.org fields:

    activity = <Date 2013-03-18.09:22:06.754>
actor = 'giampaolo.rodola'
assignee = 'giampaolo.rodola'
closed = True
closed_date = <Date 2013-03-18.09:22:06.755>
closer = 'giampaolo.rodola'
components = ['Library (Lib)']
creation = <Date 2013-03-18.06:19:27.972>
creator = 'rkackley'
dependencies = []
files = ['29438']
hgrepos = []
issue_num = 17452
keywords = ['patch']
message_count = 3.0
messages = ['184429', '184440', '184441']
nosy_count = 3.0
nosy_names = ['giampaolo.rodola', 'python-dev', 'rkackley']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17452'
versions = ['Python 3.4']
    @rkackley
    Copy link
    Mannequin Author

    rkackley mannequin commented Mar 18, 2013

    On a system with no ssl module the following test failure occurs:

    ======================================================================
    ERROR: test_dir (test.test_ftplib.TestFTPClass)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/home/rkackley/Code/cpython/Lib/test/test_ftplib.py", line 598, in test_dir
    self.client.dir(lambda x: l.append(x))
  File "/home/rkackley/Code/cpython/Lib/ftplib.py", line 565, in dir
    self.retrlines(cmd, func)
  File "/home/rkackley/Code/cpython/Lib/ftplib.py", line 476, in retrlines
    if isinstance(conn, _SSLSocket):
TypeError: isinstance() arg 2 must be a type or tuple of types

    @rkackley rkackley mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Mar 18, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 18, 2013

    New changeset 0842c5411ed6 by Giampaolo Rodola' in branch 'default':
    (bpo-17452 / ftplib) fix TypeError occurring in case ssl module is not installed
    http://hg.python.org/cpython/rev/0842c5411ed6

    @giampaolo
    Copy link
    Contributor

    Fixed, thanks.

    @giampaolo giampaolo self-assigned this Mar 18, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @giampaolo giampaolo

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @giampaolo