Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC6 build patch for python3000 #46068

Closed
ocean-city mannequin opened this issue Jan 3, 2008 · 5 comments
Closed

VC6 build patch for python3000 #46068

ocean-city mannequin opened this issue Jan 3, 2008 · 5 comments
Labels
build The build process and cross-build

Comments

@ocean-city
Copy link
Mannequin

ocean-city mannequin commented Jan 3, 2008

BPO 1727
Nosy @tiran
Files
  • vc6-py3k.patch
  • PC_VC6.zip
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-01-04.15:35:17.429>
created_at = <Date 2008-01-03.10:44:42.498>
labels = ['build']
title = 'VC6 build patch for python3000'
updated_at = <Date 2008-01-06.22:29:44.291>
user = 'https://bugs.python.org/ocean-city'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:44.291>
actor = 'admin'
assignee = 'none'
closed = True
closed_date = <Date 2008-01-04.15:35:17.429>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2008-01-03.10:44:42.498>
creator = 'ocean-city'
dependencies = []
files = ['9048', '9059']
hgrepos = []
issue_num = 1727
keywords = ['patch']
message_count = 5.0
messages = ['59127', '59129', '59222', '59229', '59232']
nosy_count = 2.0
nosy_names = ['ocean-city', 'christian.heimes']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1727'
versions = ['Python 3.0']
    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented Jan 3, 2008

    Build succeeded. So many errors on test_mailbox.py, and following error
    on test_float.py were reported.

    ======================================================================
    FAIL: test_nan_from_str (main.InfNanTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "test_float.py", line 203, in test_nan_from_str
    self.assert_(isnan(float("nan")))
AssertionError: None

    # I renamed 'fortran' in Include/abstract.h to 'fort' because VC6
    said 'fortran' is preserved word for compatibility sake.

    @ocean-city ocean-city mannequin added the build The build process and cross-build label Jan 3, 2008
    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented Jan 3, 2008

    Hello. I noticed PC/VS7.1/pythoncore.vcproj lacks Modules/md5module.c
    while creating this patch. Thank you.

    @tiran
    Copy link
    Member

    tiran commented Jan 4, 2008

    I've applied a fraction of your patch in r59711 but the part for PC/VS6
    didn't apply. It may be a newline problem. Can you send me the files in
    a zip or tar archive, please?

    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented Jan 4, 2008

    Thank you. This file is zipped file.

    @tiran
    Copy link
    Member

    tiran commented Jan 4, 2008

    Committed in 59720

    Thanks Hiro! I still wonder why you are still using VS6 :)

    @tiran tiran closed this as completed Jan 4, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran