New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reap threads in test_capi #61451
Comments
The attached patch fixes the following warning: $ ./python -m test test_capi
[1/1] test_capi
Warning -- threading._dangling was modified by test_capi
1 test altered the execution environment:
test_capi This test was introduced in f7993dc6bf26, and it seems to predate unittest. Maybe it should be moved outside test_main while we are at it. |
Looks like a straightforward translation to me. There's no obvious reason not to move it to being a real test, which means it would sure be nice if we knew why it was left in test_main. |
The attached patch converts the function in a real test, using proper skips and assert methods. |
Looks good to to me. |
This test was introduced in a4154dd5939a. |
New changeset c6ca87fbea39 by Ezio Melotti in branch '2.7': New changeset 329732a1572f by Ezio Melotti in branch '3.2': New changeset 81f98372f893 by Ezio Melotti in branch '3.3': New changeset f716a178b4e1 by Ezio Melotti in branch 'default': |
Fixed, thanks for the reviews! |
New changeset 041d0f68c67d by Ezio Melotti in branch '2.7': New changeset 01fdf24c9d75 by Ezio Melotti in branch '3.2': New changeset eb9edac39751 by Ezio Melotti in branch '3.3': New changeset cb46ccdc226a by Ezio Melotti in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: