Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resort Misc/NEWS #61423

Closed
serhiy-storchaka opened this issue Feb 17, 2013 · 20 comments
Closed

Resort Misc/NEWS #61423

serhiy-storchaka opened this issue Feb 17, 2013 · 20 comments
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 17221
Nosy @birkenfeld, @terryjreedy, @gpshead, @pitrou, @tiran, @ned-deily, @ezio-melotti, @merwok, @serhiy-storchaka
Files
  • NEWS-3.4.patch: Patch for 3.4
  • NEWS-3.4_2.patch: Patch for 3.4
  • NEWS-3.4_3.patch
  • NEWS-3.4_4.diff: 2 more fixes
  • NEWS-3.4_5.patch: Patch for 3.4
  • NEWS-3.3.patch: Patch for 3.3
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-10-18.14:06:29.134>
created_at = <Date 2013-02-17.21:15:41.704>
labels = ['type-feature', 'docs']
title = 'Resort Misc/NEWS'
updated_at = <Date 2013-10-18.14:06:29.134>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-10-18.14:06:29.134>
actor = 'serhiy.storchaka'
assignee = 'docs@python'
closed = True
closed_date = <Date 2013-10-18.14:06:29.134>
closer = 'serhiy.storchaka'
components = ['Documentation']
creation = <Date 2013-02-17.21:15:41.704>
creator = 'serhiy.storchaka'
dependencies = []
files = ['29107', '29113', '29116', '29676', '29711', '29712']
hgrepos = []
issue_num = 17221
keywords = ['patch']
message_count = 20.0
messages = ['182282', '182287', '182295', '182313', '182317', '182318', '182319', '182325', '182328', '182330', '185979', '185983', '185985', '185988', '186199', '186200', '186925', '186926', '192374', '199986']
nosy_count = 12.0
nosy_names = ['georg.brandl', 'terry.reedy', 'gregory.p.smith', 'pitrou', 'christian.heimes', 'ned.deily', 'ezio.melotti', 'eric.araujo', 'docs@python', 'python-dev', 'sbt', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17221'
versions = ['Python 3.3', 'Python 3.4']
    @serhiy-storchaka
    Copy link
    Member Author

    The proposed patch moves some Misc/NEWS entities to more appropriate sections (IDLE, C-API, Tests, Documentation, Tools/Demos). Please review.

    @serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Feb 17, 2013
    @pitrou
    Copy link
    Member

    pitrou commented Feb 17, 2013

    unittest is a library, not a part of the test suite, so its enhancements should remain in the library section.

    @ned-deily
    Copy link
    Member

    kbk has requested in the past that IDLE News items be put in Lib/idlelib/News.txt because it is installed with IDLE and there is a button to display it included in the "About IDLE" window. I know we've not been diligent about doing that, at least, I haven't. I suppose the items could continue to be put in Misc/NEWS and, prior to each release, copied into the News.txt. That step could be added to the release manager's checklist. But, if there are IDLE items in Misc/NEWS, whether duplicated or not, I agree it would be better to have them in their own section.

    @serhiy-storchaka
    Copy link
    Member Author

    Here is an updated patch. Changes for unittest and doctest reverted.

    @sbt
    Copy link
    Mannequin

    sbt mannequin commented Feb 18, 2013

    I did not realize there was a 'Extension Modules' section. I have been putting changes to C extensions in the 'Library' section instead. It looks like most people do the same as me.

    @pitrou
    Copy link
    Member

    pitrou commented Feb 18, 2013

    I did not realize there was a 'Extension Modules' section. I have
    been putting changes to C extensions in the 'Library' section
    instead. It looks like most people do the same as me.

    I prefer "Library" as well. I think the "Extension Modules" section
    should be yanked.

    @serhiy-storchaka
    Copy link
    Member Author

    Was not it be yanked in 1fabff717ef4?

    @sbt
    Copy link
    Mannequin

    sbt mannequin commented Feb 18, 2013

    Was not it be yanked in 1fabff717ef4?

    Looks like it was reintroduced by this merge changeset:

    http://hg.python.org/cpython/rev/30fc620e240e

    @gpshead
    Copy link
    Member

    gpshead commented Feb 18, 2013

    re-yank it. that was unintentional. less sections == better.

    @serhiy-storchaka
    Copy link
    Member Author

    Here is an updated patch. Re-yanked "Extension Modules" section. Changes for 3.4 sorted in chronological order.

    @ezio-melotti
    Copy link
    Member

    Serhiy, can you update and commit the patch?
    A new IDLE section would be especially useful for bpo-17506.

    @terryjreedy
    Copy link
    Member

    Has anyone checked that the last patch is basically correct?
    Which is to say, does every entry removed get put back someplace?

    I tried to import the last patch, NEWS-3.4_3.patch
    73/74 chumks were applied, 1 rejected, which can be hand edited.
    I am willing to do that if the sanity check has been done.
    (I personally would have done this in multiple patches, like moving only IDLE issues for one patch, that would have been easier to check.)

    @terryjreedy
    Copy link
    Member

    That was easy. The .patch has a space at the end of this line:

    • Issue bpo-17028: Allowed Python arguments to be supplied to the Windows
      which the file, of course, does not. That removed and it applies cleanly.

    @terryjreedy
    Copy link
    Member

    There is also this double entry before and after the patch. This is current patch with space and duplicate removed.

    • Issue bpo-15116: Remove references to appscript as it is no longer being
      supported.

    • Issue bpo-15116: Remove references to appscript as it is no longer being
      supported.

    @serhiy-storchaka
    Copy link
    Member Author

    Thank you, Terry. Here is a new version of a patch for 3.4. New entries move, IDLE section resorted in a chronological order, duplicates removed, some minor things fixed.

    @serhiy-storchaka
    Copy link
    Member Author

    And here is a patch for 3.3.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 14, 2013

    New changeset dbb943399c9b by Serhiy Storchaka in branch '2.7':
    Issue bpo-17221: Resort Misc/NEWS.
    http://hg.python.org/cpython/rev/dbb943399c9b

    New changeset 7da08495b497 by Serhiy Storchaka in branch '3.3':
    Issue bpo-17221: Resort Misc/NEWS.
    http://hg.python.org/cpython/rev/7da08495b497

    New changeset 6fdcea9e89a3 by Serhiy Storchaka in branch 'default':
    Issue bpo-17221: Resort Misc/NEWS.
    http://hg.python.org/cpython/rev/6fdcea9e89a3

    @serhiy-storchaka
    Copy link
    Member Author

    I commit patches since no one objected.

    Not all errors are corrected. There are duplicates (cat [Misc/NEWS](https://github.com/python/cpython/blob/main/Misc/NEWS) | sort | uniq -cd | sort -n). I'm not sure that the line "What's New in Python 3.3.1 release candidate 1?" in Misc/NEWS for 3.4 correct. The difference between 3.3 and 3.4 is more than expected (hg diff -r 3.3 -r default [Misc/NEWS](https://github.com/python/cpython/blob/main/Misc/NEWS)).

    @tiran
    Copy link
    Member

    tiran commented Jul 5, 2013

    I think this issue can be closed. :)

    @tiran tiran closed this as completed Jul 5, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 15, 2013

    New changeset 484ce82b7873 by Serhiy Storchaka in branch 'default':
    Issue bpo-17221: Merge 3.4.0 Alpha 1 entries before and after 3.3.1 release candidate 1.
    http://hg.python.org/cpython/rev/484ce82b7873

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    7 participants
    @gpshead @tiran @pitrou @serhiy-storchaka @ned-deily @terryjreedy @ezio-melotti