New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tk 8.6.0 introduces TypeError. (Tk 8.5.13 works) #61013
Comments
I am running Arch Linux with the latest Tcl/Tk 8.6.0 build with Python 2.7.3 and 3.3.0, and the latest 3.4.0a0 build from the repository. Running the attached script fails when calling pack_info(). Here's is the script's output: 8.6
Traceback (most recent call last):
File "tk_86_error.py", line 6, in <module>
label.pack_info()
File "/usr/lib/python3.3/tkinter/__init__.py", line 1884, in pack_info
self.tk.call('pack', 'info', self._w))
TypeError: Can't convert '_tkinter.Tcl_Obj' object to str implicitly This error did not occur when using Tk 8.5.13. |
In Objects/unicodeobject.c in PyUnicode_FromObject, the call to PyUnicode_CheckExact fails when using 8.6.0 but works with 8.5.13. |
I don't install Tcl/Tk 8.6 yet, but looks as "pack info" call returns a new type of Tcl data (perhaps DictType) which doesn't detected in FromObj(). |
The simplest fix probably is just wrap self.tk.call() with str() (I have not tested it yet). However the problem is more serious (tkinter doesn't support fully even 8.5 and subtle bugs are possible) and I'll spend some more time on its research. |
Here is a patch which add support of Tcl_Obj to tkinter's splitlist(). This not only fixes some incompatibility with Tk 8.6, but can fix some issues with older Tk versions (see for example bpo-17397). |
Serhiy, I applied your patch but I still get the same error. From what I have found so far, the FromObj function in Modules/_tkinter.c relies on cached values for different Tcl_ObjType, as given in the TkappObject struct. From the comment:
I haven't traced down the exact difference between 8.5 and 8.6 that causes the existing cached types to not match. The correct behavior from 8.5 is a match to "StringType". I've noticed a lot more macros in the 8.6 headers than in 8.5 which may be the culprit. |
The problem I'm encountering is that tk.splitlist() is now being given a Tcl_Obj instead of a "str" type. Since everything is Tcl is a string, explicitly casting a Tcl_Obj to a string seems reasonable. Attached is some proof-of-concept code to work around the issue. Serhiy's patch against 3.4 gives this traceback: [python@saturn 3.4]$ ./python tk_86_error.py
8.6
Traceback (most recent call last):
File "tk_86_error.py", line 6, in <module>
label.pack_info()
File "/home/python/python/3.4/Lib/tkinter/__init__.py", line 1924, in pack_info
if value[:1] == '.':
TypeError: '_tkinter.Tcl_Obj' object is not subscriptable |
Yes, I considered this option. A sure way to get rid of this and future changes in Tcl types, is get rid of Tcl_Obj at all and always return strings (if it is not a number or list). The drawback of this method is that occurs unnecessary conversion between Tcl and Python types and that information about types is lost. Also it is possible to hamper support for new Tcl types (dict, StateSpec, etc) in future. Another way is much more difficult. We need to allow all Tkinter functions to accept Tcl_Obj. Unfortunately this doesn't solve the problem fully because other code might expect a string instead of Tcl_Obj. We don't have enough test coverage to verify that the changes are sufficient. In any case, there are third-party code, which will also have to change to support the new Tcl versions. |
Here are a patch which quickly switch off Tcl_Obj. |
And here is a patch which allows Tk.splitline() and Tk.split() to work with Tcl_Obj. It also includes some other minor fixes to support Tcl 8.6. The patch includes a fix for bpo-18101. |
Please commit the full patch in all active branches. |
Hello. #test.py
import tkinter as tk
root = tk.Tk()
b = tk.Button(root, text='Button')
b.grid()
print(b.grid_info())
root.mainloop() Here's is the script's output: alejandro@vostro1:~/tmp$ cpython3.3 test.py
Traceback (most recent call last):
File "test.py", line 10, in <module>
print(b.grid_info())
File "/home/alejandro/apps/cpython3.3.2/lib/python3.3/tkinter/__init__.py", line 2024, in grid_info
if value[:1] == '.':
TypeError: '_tkinter.Tcl_Obj' object is not subscriptable |
New changeset 6b841e1ee3b8 by Serhiy Storchaka in branch '3.3': New changeset 85285e6e28f4 by Serhiy Storchaka in branch 'default': New changeset 2d96764a66fa by Serhiy Storchaka in branch '2.7': |
New changeset 516b0cd87a90 by Serhiy Storchaka in branch '3.3': New changeset 5b5ef012cd4e by Serhiy Storchaka in branch 'default': New changeset 06244031b608 by Serhiy Storchaka in branch '2.7': |
Thank you alejandro. Fixed. I'm afraid this is not all problems with 8.6 and so left this issue open. |
Since there are no other reports about 8.6 I close this issue. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: