Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_timeout refactoring #44689

Closed
sonderblade mannequin opened this issue Mar 10, 2007 · 6 comments
Closed

test_timeout refactoring #44689

sonderblade mannequin opened this issue Mar 10, 2007 · 6 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@sonderblade
Copy link
Mannequin

sonderblade mannequin commented Mar 10, 2007

BPO 1677694
Nosy @pitrou
Dependencies
  • bpo-728815: test_timeout updates
    		•
    Files
  • refactor-test-timeout.patch: Refactor test_timeout.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2011-01-06.09:06:18.498>
created_at = <Date 2007-03-10.00:49:51.000>
labels = ['type-feature', 'tests']
title = 'test_timeout refactoring'
updated_at = <Date 2011-01-06.09:06:18.496>
user = 'https://bugs.python.org/sonderblade'

    bugs.python.org fields:

    activity = <Date 2011-01-06.09:06:18.496>
actor = 'pitrou'
assignee = 'collinwinter'
closed = True
closed_date = <Date 2011-01-06.09:06:18.498>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2007-03-10.00:49:51.000>
creator = 'sonderblade'
dependencies = ['728815']
files = ['7851']
hgrepos = []
issue_num = 1677694
keywords = ['patch']
message_count = 6.0
messages = ['52144', '52145', '52146', '110531', '116626', '125528']
nosy_count = 4.0
nosy_names = ['collinwinter', 'sonderblade', 'pitrou', 'BreamoreBoy']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1677694'
versions = ['Python 3.2']
    @sonderblade
    Copy link
    Mannequin Author

    sonderblade mannequin commented Mar 10, 2007

    Please see bpo-728815. https://sourceforge.net/tracker/index.php?func=detail&aid=728815&group_id=5470&atid=305470

    @collinwinter
    Copy link
    Mannequin

    collinwinter mannequin commented Mar 10, 2007

    In a comment on patch bpo-728815, you (Bjorn) said, "[p]lus, (I think) it fixes a bug which (I think) only happens when you access the internet from behind a web proxy." Could you split any bug fixes into a patch separate from the code cleanup and refactoring? That will make reviewing it/them easier.

    @sonderblade
    Copy link
    Mannequin Author

    sonderblade mannequin commented Mar 10, 2007

    But the bugfix is so simple. :) The original author Dmitry Vasiliev claimed that connecting to www.google.com with port 80 did not always work for him because of a transparent proxy. I believe what he meant was that connection was not guaranteed to timeout. So he changed the port to 21 which www.google.com does not respond to.

    @devdanzin devdanzin mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Mar 30, 2009
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 17, 2010

    The patch is purely a change to unit test code involving sockets, anyone with experience of these who could review the patch?

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Sep 16, 2010

    Could someone with commit privileges please take this forward?

    @pitrou
    Copy link
    Member

    pitrou commented Jan 6, 2011

    I adapted the patch for current py3k and committed it in r87786. Thank you for your patience.

    @pitrou pitrou closed this as completed Jan 6, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou