Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"tel" URIs should support params #60917

Closed
pitrou opened this issue Dec 18, 2012 · 5 comments
Closed

"tel" URIs should support params #60917

pitrou opened this issue Dec 18, 2012 · 5 comments
Assignees
@orsenthil
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Dec 18, 2012

BPO 16713
Nosy @amauryfa, @orsenthil, @pitrou, @merwok

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2012-12-24.22:05:31.772>
created_at = <Date 2012-12-18.14:30:24.232>
labels = ['type-bug', 'library']
title = '"tel" URIs should support params'
updated_at = <Date 2012-12-24.22:05:31.771>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2012-12-24.22:05:31.771>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2012-12-24.22:05:31.772>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2012-12-18.14:30:24.232>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 16713
keywords = []
message_count = 5.0
messages = ['177692', '177693', '177885', '178106', '178107']
nosy_count = 5.0
nosy_names = ['amaury.forgeotdarc', 'orsenthil', 'pitrou', 'eric.araujo', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue16713'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']
@pitrou
Copy link
Member Author

pitrou commented Dec 18, 2012

RFC 3966 (http://tools.ietf.org/html/rfc3966) defines the tel URI and its parameters. However, urlparse / urllib.parse doesn't recognize "tel" URIs as taking parameters:

>>> urlparse.urlparse('tel:7042;phone-context=example.com')
ParseResult(scheme='tel', netloc='', path='7042;phone-context=example.com', params='', query='', fragment='')

@pitrou pitrou added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Dec 18, 2012
@amauryfa
Copy link
Member

I don't know whether 'tel' is a common scheme, but it's easy to add it to urlparse from the outside:

>>> urlparse.uses_param.append('tel')
>>> urlparse.urlparse('tel:7042;phone-context=example.com')
ParseResult(scheme='tel', netloc='', path='7042', params='phone-context=example.com', query='', fragment='')

@merwok
Copy link
Member

merwok commented Dec 21, 2012

It’s easy sure, but I think it’s still a bug :)

@python-dev
Copy link
Mannequin

python-dev mannequin commented Dec 24, 2012

New changeset d002a2e46383 by Senthil Kumaran in branch '3.2':
Fix bpo-16713 - tel url parsing with params
http://hg.python.org/cpython/rev/d002a2e46383

New changeset 727f26d1806f by Senthil Kumaran in branch '3.3':
Fix bpo-16713 - tel url parsing with params
http://hg.python.org/cpython/rev/727f26d1806f

New changeset e147d5f3c897 by Senthil Kumaran in branch 'default':
Fix bpo-16713 - tel url parsing with params
http://hg.python.org/cpython/rev/e147d5f3c897

New changeset ff0426b5d75e by Senthil Kumaran in branch '2.7':
Fix bpo-16713 - tel url parsing with params
http://hg.python.org/cpython/rev/ff0426b5d75e

@orsenthil
Copy link
Member

Fixed in all codelines. Thank you!

@orsenthil orsenthil self-assigned this Dec 24, 2012
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orsenthil orsenthil

Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orsenthil @merwok @amauryfa @pitrou