Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"World" tool ported to py3k #46012

Closed
quentingallet-gilles mannequin opened this issue Dec 20, 2007 · 6 comments
Closed

"World" tool ported to py3k #46012

quentingallet-gilles mannequin opened this issue Dec 20, 2007 · 6 comments
Assignees
@warsaw

Comments

@quentingallet-gilles
Copy link
Mannequin

quentingallet-gilles mannequin commented Dec 20, 2007

BPO 1671
Nosy @gvanrossum, @warsaw, @tiran
Files
  • world_tool.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/warsaw'
closed_at = <Date 2007-12-20.15:58:02.151>
created_at = <Date 2007-12-20.13:30:23.723>
labels = []
title = '"World" tool ported to py3k'
updated_at = <Date 2008-01-06.22:29:44.362>
user = 'https://bugs.python.org/quentingallet-gilles'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:44.362>
actor = 'admin'
assignee = 'barry'
closed = True
closed_date = <Date 2007-12-20.15:58:02.151>
closer = 'barry'
components = ['Demos and Tools']
creation = <Date 2007-12-20.13:30:23.723>
creator = 'quentin.gallet-gilles'
dependencies = []
files = ['9011']
hgrepos = []
issue_num = 1671
keywords = ['patch']
message_count = 6.0
messages = ['58874', '58881', '58883', '58889', '58895', '58897']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'barry', 'christian.heimes', 'quentin.gallet-gilles']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1671'
versions = ['Python 3.0']
    @quentingallet-gilles
    Copy link
    Mannequin Author

    quentingallet-gilles mannequin commented Dec 20, 2007

    The title says it all.

    I also updated the country codes and other TLDs as things have evolved a
    bit since 2002.

    @tiran
    Copy link
    Member

    tiran commented Dec 20, 2007

    Thx :)

    @quentingallet-gilles
    Copy link
    Mannequin Author

    quentingallet-gilles mannequin commented Dec 20, 2007

    You're welcome :-)

    @gvanrossum
    Copy link
    Member

    Maybe the original author (Barry Warsaw) can review this?

    @warsaw
    Copy link
    Member

    warsaw commented Dec 20, 2007

    The change looks good to me, thanks! I made a minor change to your
    patch (i.e. .keys() not needed in sorted()), did some whitespace
    normalization, and fixed up the --dump output. Otherwise, the patch is
    quentin's and I've committed it to the tree.

    r59581

    @warsaw warsaw closed this as completed Dec 20, 2007
    @quentingallet-gilles
    Copy link
    Mannequin Author

    quentingallet-gilles mannequin commented Dec 20, 2007

    That was quick, thanks!

    I'll make sure to remember that sorted() and keys() aren't needed together.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @warsaw warsaw

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @warsaw @tiran @gvanrossum