Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that audioop works with bytes, not strings #60886

Closed
serhiy-storchaka opened this issue Dec 14, 2012 · 3 comments
Closed

Document that audioop works with bytes, not strings #60886

serhiy-storchaka opened this issue Dec 14, 2012 · 3 comments
Assignees
@serhiy-storchaka
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 16682
Nosy @terryjreedy, @serhiy-storchaka
Files
  • audioop_docs_bytes.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2012-12-27.18:54:15.661>
created_at = <Date 2012-12-14.17:27:44.739>
labels = ['type-feature', 'docs']
title = 'Document that audioop works with bytes, not strings'
updated_at = <Date 2012-12-27.18:54:15.661>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2012-12-27.18:54:15.661>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2012-12-27.18:54:15.661>
closer = 'serhiy.storchaka'
components = ['Documentation']
creation = <Date 2012-12-14.17:27:44.739>
creator = 'serhiy.storchaka'
dependencies = []
files = ['28312']
hgrepos = []
issue_num = 16682
keywords = ['patch']
message_count = 3.0
messages = ['177474', '177906', '178309']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'docs@python', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16682'
versions = ['Python 3.2', 'Python 3.3', 'Python 3.4']
    @serhiy-storchaka
    Copy link
    Member Author

    The audioop module documentation says that functions works with Python strings. This was right in 2.x, but in 3.x here should be bytes objects (actually the functions accept strings too, but this is an implementation detail, meaningless in general).

    @serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Dec 14, 2012
    @terryjreedy
    Copy link
    Member

    Patch looks good to me, all three occurrences of 'string' are fixed.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 27, 2012

    New changeset cd2b4074a2d9 by Serhiy Storchaka in branch '3.2':
    Issue bpo-16682: Replace "Python string" to "bytes object" in audioop documentation.
    http://hg.python.org/cpython/rev/cd2b4074a2d9

    New changeset e8248e597060 by Serhiy Storchaka in branch '3.3':
    Issue bpo-16682: Replace "Python string" to "bytes object" in audioop documentation.
    http://hg.python.org/cpython/rev/e8248e597060

    New changeset f68aeab64356 by Serhiy Storchaka in branch 'default':
    Issue bpo-16682: Replace "Python string" to "bytes object" in audioop documentation.
    http://hg.python.org/cpython/rev/f68aeab64356

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @terryjreedy