Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context manager support to epoll object #60692

Closed
serhiy-storchaka opened this issue Nov 16, 2012 · 5 comments
Closed

Add context manager support to epoll object #60692

serhiy-storchaka opened this issue Nov 16, 2012 · 5 comments
Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 16488
Nosy @jcea, @pitrou, @asvetlov, @serhiy-storchaka
Files
  • select_epoll_context_manager.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2012-12-15.20:17:44.107>
created_at = <Date 2012-11-16.15:14:09.072>
labels = ['extension-modules', 'type-feature']
title = 'Add context manager support to epoll object'
updated_at = <Date 2013-01-27.02:02:56.865>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-01-27.02:02:56.865>
actor = 'jcea'
assignee = 'none'
closed = True
closed_date = <Date 2012-12-15.20:17:44.107>
closer = 'pitrou'
components = ['Extension Modules']
creation = <Date 2012-11-16.15:14:09.072>
creator = 'serhiy.storchaka'
dependencies = []
files = ['28003']
hgrepos = []
issue_num = 16488
keywords = ['patch']
message_count = 5.0
messages = ['175693', '175702', '176192', '177558', '177559']
nosy_count = 5.0
nosy_names = ['jcea', 'pitrou', 'asvetlov', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16488'
versions = ['Python 3.4']
    @serhiy-storchaka
    Copy link
    Member Author

    The proposed patch adds support of context manager protocol to epoll objects.

    @serhiy-storchaka serhiy-storchaka added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Nov 16, 2012
    @pitrou
    Copy link
    Member

    pitrou commented Nov 16, 2012

    I don't think that's very useful since generally the epoll object will have to survive accross function calls (it's usually stored as an attribute somewhere on your event loop).

    On the other hand, this addition doesn't hurt.

    @asvetlov
    Copy link
    Contributor

    +0 for patch

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 15, 2012

    New changeset d6f61cd364d9 by Antoine Pitrou in branch 'default':
    Issue bpo-16488: epoll() objects now support the with statement.
    http://hg.python.org/cpython/rev/d6f61cd364d9

    @pitrou
    Copy link
    Member

    pitrou commented Dec 15, 2012

    Committed, thank you!

    @pitrou pitrou closed this as completed Dec 15, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @asvetlov @pitrou @serhiy-storchaka