Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New @spam.getter property syntax modifies the property in place #45961

Closed
tiran opened this issue Dec 14, 2007 · 2 comments
Closed

New @spam.getter property syntax modifies the property in place #45961

tiran opened this issue Dec 14, 2007 · 2 comments
Assignees
@tiran
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@tiran
Copy link
Member

tiran commented Dec 14, 2007

BPO 1620
Nosy @gvanrossum, @tiran
Files
  • py3k_copy_property.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2007-12-14.02:02:11.501>
created_at = <Date 2007-12-14.00:26:26.145>
labels = ['interpreter-core']
title = 'New @spam.getter property syntax modifies the property in place'
updated_at = <Date 2008-01-06.22:29:44.444>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:44.444>
actor = 'admin'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2007-12-14.02:02:11.501>
closer = 'christian.heimes'
components = ['Interpreter Core']
creation = <Date 2007-12-14.00:26:26.145>
creator = 'christian.heimes'
dependencies = []
files = ['8947']
hgrepos = []
issue_num = 1620
keywords = ['patch']
message_count = 2.0
messages = ['58598', '58607']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'christian.heimes']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1620'
versions = ['Python 2.6', 'Python 3.0']
    @tiran
    Copy link
    Member Author

    tiran commented Dec 14, 2007

    As reported by Duncan Booth at
    http://permalink.gmane.org/gmane.comp.python.general/551183 the new
    @spam.getter syntax modifies the property in place but it should create
    a new one.

    The patch is the first draft of a fix. I've to write unit tests to
    verify the patch. It copies the property and as a bonus grabs the
    __doc__ string from the getter if the doc string initially came from the
    getter as well.

    @tiran tiran self-assigned this Dec 14, 2007
    @tiran tiran added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 14, 2007
    @tiran
    Copy link
    Member Author

    tiran commented Dec 14, 2007

    Fixed in r59488

    @tiran tiran closed this as completed Dec 14, 2007
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran