Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 424 #60352

Closed
alex opened this issue Oct 6, 2012 · 11 comments
Closed

Implement PEP 424 #60352

alex opened this issue Oct 6, 2012 · 11 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@alex
Copy link
Member

alex commented Oct 6, 2012

BPO 16148
Nosy @tiran, @mitsuhiko, @alex, @skrah
Files
  • length_hint.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2012-10-06.12:14:02.263>
created_at = <Date 2012-10-06.10:46:13.292>
labels = ['interpreter-core', 'type-feature']
title = 'Implement PEP 424'
updated_at = <Date 2012-10-07.08:29:40.745>
user = 'https://github.com/alex'

    bugs.python.org fields:

    activity = <Date 2012-10-07.08:29:40.745>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2012-10-06.12:14:02.263>
closer = 'aronacher'
components = ['Interpreter Core']
creation = <Date 2012-10-06.10:46:13.292>
creator = 'alex'
dependencies = []
files = ['27451']
hgrepos = []
issue_num = 16148
keywords = ['patch']
message_count = 11.0
messages = ['172176', '172183', '172184', '172185', '172188', '172189', '172190', '172203', '172208', '172239', '172281']
nosy_count = 5.0
nosy_names = ['christian.heimes', 'aronacher', 'alex', 'skrah', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16148'
versions = ['Python 3.4']
    @alex
    Copy link
    Member Author

    alex commented Oct 6, 2012

    The attached patch implements PEP-424. The implementation of this demonstrated a need for a few small modifications to the PEP, they will follow shortly.

    @alex alex added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Oct 6, 2012
    @alex
    Copy link
    Member Author

    alex commented Oct 6, 2012

    patch updated fully with respect to the updates georg pushed to the PEP

    @alex
    Copy link
    Member Author

    alex commented Oct 6, 2012

    Updated version of the patch with fewer memory leaks.

    @alex
    Copy link
    Member Author

    alex commented Oct 6, 2012

    All memory leaks resolved, yay!

    @alex
    Copy link
    Member Author

    alex commented Oct 6, 2012

    Added documentation.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 6, 2012

    New changeset a7ec0a1b0f7c by Armin Ronacher in branch 'default':
    Issue bpo-16148: implemented PEP-424
    http://hg.python.org/cpython/rev/a7ec0a1b0f7c

    @mitsuhiko
    Copy link
    Member

    Reviewed and applied. Looks good.

    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Oct 6, 2012

    a7ec0a1b0f7c broke the Windows buildbots: In Visual Studio variables
    can only be declared at the top of a block.

    @tiran
    Copy link
    Member

    tiran commented Oct 6, 2012

    I've taken care of the issue in f56a49e74178 and 895f9fddb8e3.

    @alex
    Copy link
    Member Author

    alex commented Oct 6, 2012

    Ah, thank you very much, sorry about that.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 7, 2012

    New changeset b9dedf845a0f by Armin Ronacher in branch 'default':
    Issue bpo-16148: Small improvements and cleanup. Added version information
    http://hg.python.org/cpython/rev/b9dedf845a0f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @alex @mitsuhiko @tiran