Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make altinstall" installs pydoc, idle, smtpd.py #45931

Closed
dripton mannequin opened this issue Dec 11, 2007 · 10 comments
Closed

"make altinstall" installs pydoc, idle, smtpd.py #45931

dripton mannequin opened this issue Dec 11, 2007 · 10 comments
Labels
build The build process and cross-build topic-installation type-bug An unexpected behavior, bug, or error

Comments

@dripton
Copy link
Mannequin

dripton mannequin commented Dec 11, 2007

BPO 1590
Nosy @gvanrossum, @tiran, @devdanzin, @benjaminp, @ned-deily
Dependencies
  • bpo-1120: "make altinstall" installs pydoc, idle, smtpd.py with broken shebang lines
    		•
    Files
  • altinstall.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2009-04-07.19:28:05.500>
created_at = <Date 2007-12-11.15:48:35.299>
labels = ['type-bug', 'expert-installation', 'build']
title = '"make altinstall" installs pydoc, idle, smtpd.py'
updated_at = <Date 2009-04-14.20:28:56.804>
user = 'https://bugs.python.org/dripton'

    bugs.python.org fields:

    activity = <Date 2009-04-14.20:28:56.804>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2009-04-07.19:28:05.500>
closer = 'benjamin.peterson'
components = ['Build', 'Installation']
creation = <Date 2007-12-11.15:48:35.299>
creator = 'dripton'
dependencies = ['1120']
files = ['8931']
hgrepos = []
issue_num = 1590
keywords = ['patch']
message_count = 10.0
messages = ['58437', '58450', '58462', '58492', '58493', '85734', '85735', '85738', '85785', '85974']
nosy_count = 6.0
nosy_names = ['gvanrossum', 'dripton', 'christian.heimes', 'ajaksu2', 'benjamin.peterson', 'ned.deily']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1590'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']
    @dripton
    Copy link
    Mannequin Author

    dripton mannequin commented Dec 11, 2007

    Python 3.0a2, Gentoo Linux, x86

    "make altinstall" installs idle, pydoc, and smtpd.py

    This can partially break the previous Python install, which is counter
    to the idea of altinstall being safe to use in parallel with an existing
    install of a different version of Python.

    IMO altinstall should install no files that lack a version number
    somewhere in their path. I suggest having altinstall simply not install
    pydoc, idle, and smtpd.py.

    @dripton dripton mannequin added build The build process and cross-build type-bug An unexpected behavior, bug, or error labels Dec 11, 2007
    @gvanrossum
    Copy link
    Member

    Agreed. Please provide a patch. Isn't this a 2.5-2.6 issue as well?

    @tiran
    Copy link
    Member

    tiran commented Dec 11, 2007

    Yes, 2.5 and 2.6 are affected, too. The scripts are install by setup.py
    in sharedinstall.

    @dripton
    Copy link
    Mannequin Author

    dripton mannequin commented Dec 12, 2007

    Here's a patch, against the 3.0a2 tarball.

    @dripton
    Copy link
    Mannequin Author

    dripton mannequin commented Dec 12, 2007

    Same patch appears to work fine against the 2.5.1 tarball.

    @devdanzin devdanzin mannequin added the topic-installation label Apr 6, 2009
    @dripton
    Copy link
    Mannequin Author

    dripton mannequin commented Apr 7, 2009

    I see this has been marked as "test needed", but this patch is a change
    to Makefile.pre.in, and it's not clear to me how to unit test it using
    the existing Python test framework.

    FWIW, I've manually tested it (on Linux) by doing ./configure; make;
    sudo make install and verifying the absence of (newly installed) idle,
    pydoc, and smtpd.py in /usr/local/bin

    @devdanzin
    Copy link
    Mannequin

    devdanzin mannequin commented Apr 7, 2009

    That's good enough a test for me :)
    Pinging gutworth so we can have this in 3.1.

    @benjaminp
    Copy link
    Contributor

    Fixed in r71372. Thanks for the patch!

    @benjaminp
    Copy link
    Contributor

    Refixed in r71400.

    @ned-deily
    Copy link
    Member

    r71400 breaks installer builds. See bpo-5756.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @benjaminp @tiran @gvanrossum @ned-deily